pkg/k8sutil,cmd/up/local: Fixing kubeconfig environment variable. #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
hasbro17
approved these changes
Nov 5, 2018
hasbro17
reviewed
Nov 5, 2018
pkg/k8sutil/constants.go
Outdated
| @@ -17,7 +17,7 @@ package k8sutil | |||
| const ( | |||
| // KubeConfigEnvVar defines the env variable KUBERNETES_CONFIG which | |||
There was a problem hiding this comment.
Actually the comment needs to be updated as well. Change KUBERNETES_CONFIG to KUBECONFIG.
shawn-hurley
force-pushed
the
bugfix/issue-700
branch
from
66f05d4
to
6230e28
Compare
mhrivnak
approved these changes
Nov 6, 2018
|
@shawn-hurley @hasbro17 Maybe its worth adding some more info on the user guide regarding this option.
this means even if i export KUBECONFIG i will still have to add the --kubeconfig flag with the right path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.