commands/.../test/local,pkg/test: add no-setup flag
#770
Conversation
openshift-ci-robot
added
the
size/M
AlexNPavel
force-pushed
the
test-no-setup
branch
from
c18d616
to
5182ece
Compare
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
AlexNPavel
force-pushed
the
test-no-setup
branch
from
6aab76c
to
427b377
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
AlexNPavel
force-pushed
the
test-no-setup
branch
from
f912371
to
b90d041
Compare
| @@ -57,6 +57,10 @@ type Framework struct { | |||
| } | |||
|
|
|||
| func setup(kubeconfigPath, namespacedManPath *string) error { | |||
| namespace := "" | |||
| if *singleNamespace { | |||
| namespace = os.Getenv(TestNamespaceEnv) | |||
There was a problem hiding this comment.
If len(namespace) == 0 exit with error TestNamespaceEnv must be set.
There was a problem hiding this comment.
Not necessary. We default to the namespace specified in the kubeconfig in that case: https://github.com/operator-framework/operator-sdk/pull/770/files/b7ca022a01320d6b684df1d9e4cec56c86151440#diff-7ebc985f9067a44fc5791eeec5c424e2R84
Co-Authored-By: AlexNPavel <alexpavel123@gmail.com>
|
@AlexNPavel: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@AlexNPavel: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change: Adds a
no-setupflag that disables creation of resources by using empty files as the manifests and restricting the test to a single namespaceMotivation for the change: Resolves #743