'operator-sdk print-deps' command #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
added
the
kind/feature
estroz
requested review from
mhrivnak,
joelanford,
shawn-hurley,
AlexNPavel,
lilic and
hasbro17
openshift-ci-robot
added
do-not-merge/work-in-progress
estroz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
lilic
reviewed
Nov 26, 2018
| func NewPrintDepsCmd() *cobra.Command { | ||
| printDepsCmd := &cobra.Command{ | ||
| Use: "print-deps", | ||
| Short: "Print dependencies expected by the Operator SDK", |
There was a problem hiding this comment.
Nit: Think this could be phrased a bit differently to avoid confusion, dependencies can also mean, the things we expect like requirements we depend on: e.g. dep itself, version of go, etc. WDYT?
There was a problem hiding this comment.
"Print Golang packages and versions required to run the operator"?
…mmand pkg/scaffold/gopkgtoml.go: printing utilities for print-deps
AlexNPavel
approved these changes
Nov 26, 2018
joelanford
approved these changes
Nov 26, 2018
|
@estroz Can you follow this up by updating the CHANGELOG for the new cmd. |
hasbro17
reviewed
Nov 26, 2018
| ### Flags | ||
|
|
||
| * `--as-file` Print packages and versions in Gopkg.toml format. | ||
|
|
There was a problem hiding this comment.
@estroz Sorry for the late review but it might be good to have a truncated example output here for a particular version, as we do for other commands.
We can show the --as-file output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: add an
operator-sdk print-depssub-command to print the most recent operator dependencies and versions. The sub-command will print pretty (below) by default, or the fullGopkg.tomlwhen passed the--as-fileflag.Motivation for the change: updating operator versions when upgrading to new binary versions requires looking at SDK source code. This command prints all version information for packages pre-defined by the SDK that can be copy and pasted into an operators'
Gopkg.toml, or written over directly with the--as-fileflag.Sample of output:
Closes #638