Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s dependencies to 1.12.3 #807

Merged
merged 11 commits into from
Dec 7, 2018

Conversation

estroz
Copy link
Member

@estroz estroz commented Dec 3, 2018

Description of the change: bump all kubernetes version to v1.12.2. Some pkg/helm API calls broke, which are now fixed.

Motivation for the change: new version == happy users (most of the time).

Closes #808

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2018
@estroz estroz changed the title [WIP] Kubernetes 1.12.x [WIP] bump k8s dependencies to 1.12.3 Dec 3, 2018
@estroz
Copy link
Member Author

estroz commented Dec 3, 2018

/cc @joelanford
to check helm updates

@estroz estroz changed the title [WIP] bump k8s dependencies to 1.12.3 bump k8s dependencies to 1.12.3 Dec 3, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2018
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a couple of nits.

Gopkg.toml Outdated Show resolved Hide resolved
Gopkg.toml Outdated Show resolved Hide resolved
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green 🎉 🍏

pkg/scaffold/cmd.go Outdated Show resolved Hide resolved
pkg/helm/release/manager.go Show resolved Hide resolved
@hasbro17
Copy link
Contributor

hasbro17 commented Dec 5, 2018

/hold until the controller-runtime cuts the tag for v0.1.8

@estroz estroz force-pushed the kubernetes-1.12.2 branch 4 times, most recently from ab16ee6 to 71cfb24 Compare December 7, 2018 09:33
@hasbro17
Copy link
Contributor

hasbro17 commented Dec 7, 2018

We can update to controller-runtime v0.1.8 in this PR.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2018
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2018
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 3081e30 into operator-framework:master Dec 7, 2018
@estroz estroz deleted the kubernetes-1.12.2 branch December 7, 2018 19:46
@hasbro17
Copy link
Contributor

hasbro17 commented Dec 7, 2018

@estroz Can you please submit a PR to update the CHANGELOG. We just need to point out the changes for updating to k8s 1.12.3 and controller-runtime v0.1.8.

estroz added a commit to estroz/operator-sdk that referenced this pull request Dec 19, 2018
* Gopkg.toml: kubernetes 1.12.3

* pkg/helm/release/manager*.go: fix broken API's from k8s upgrade

* bump scaffolded k8s dependencies to v1.12.3

* fix controller-runtime to v0.1.8

* bump helm to v2.12.0

* revendor
fabianvf pushed a commit to fabianvf/operator-sdk that referenced this pull request Dec 21, 2018
* Gopkg.toml: kubernetes 1.12.3

* pkg/helm/release/manager*.go: fix broken API's from k8s upgrade

* bump scaffolded k8s dependencies to v1.12.3

* fix controller-runtime to v0.1.8

* bump helm to v2.12.0

* revendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update k8s dependencies to 1.12.3
5 participants