pkg/scaffold/ansible; Add k8s_status module #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move k8s_status rendering all inside of scaffold Add tests for k8s status
openshift-ci-robot
added
the
size/L
|
/hold We need to update the SDK version in Gopkg.toml to use the branch v0.4.x so the CI runs against the branch and not the last tag v0.4.0 Wait for this PR to be merged: #974 |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
shawn-hurley
added
language/ansible
(cherry picked from commit 4af0571)
fabianvf
approved these changes
Jan 22, 2019
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
Move k8s_status rendering all inside of scaffold Add tests for k8s status <!-- Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-sdk/blob/master/CONTRIBUTING.MD Note: Make sure your branch is rebased to the latest upstream master. --> **Description of the change:** Adds k8s_status module into Ansible Operator scaffolding **Motivation for the change:** k8s_status module is missing in 0.4.0 release. <!-- Note: If this PR is fixing an issue make sure to add a note saying: Closes #<ISSUE_NUMBER> -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move k8s_status rendering all inside of scaffold
Add tests for k8s status
Description of the change:
Adds k8s_status module into Ansible Operator scaffolding
Motivation for the change:
k8s_status module is missing in 0.4.0 release.