Incorrect unique provisioner ID filtering

[timflannagan]

When deploying rukpak using the main branch images, and creating the following BundleDeployment resource:

apiVersion: core.rukpak.io/v1alpha1
kind: BundleDeployment
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"core.rukpak.io/v1alpha1","kind":"BundleDeployment","metadata":{"annotations":{},"name":"olm-v0.20.0"},"spec":{"provisionerClassName":"core-rukpak-io-plain","template":{"spec":{"provisionerClassName":"core-rukpak-io-plain","source":{"image":{"ref":"quay.io/tflannag/olm-plain-bundle:olm-v0.20.0-combined"},"type":"image"}}}}}
  creationTimestamp: "2022-08-19T20:22:39Z"
  generation: 1
  name: olm-v0.20.0
  resourceVersion: "1651"
  uid: 091f1e35-dabe-4ac3-bc26-fdb7a2e290fc
spec:
  provisionerClassName: core-rukpak-io-plain
  template:
    spec:
      provisionerClassName: core-rukpak-io-plain
      source:
        image:
          ref: quay.io/tflannag/olm-plain-bundle:olm-crds-v0.20.0
        type: image

It looks like the BundleDeployment is reporting a successful installation at the surface when querying for the resource locally, but when diving into the resource further:

$ k get bd olm-v0.20.0-api -oyaml
apiVersion: core.rukpak.io/v1alpha1
kind: BundleDeployment
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"core.rukpak.io/v1alpha1","kind":"BundleDeployment","metadata":{"annotations":{},"name":"olm-v0.20.0-api"},"spec":{"provisionerClassName":"core-rukpak-io-plain","template":{"spec":{"provisionerClassName":"core-rukpak-io-plain","source":{"image":{"ref":"quay.io/tflannag/olm-plain-bundle:olm-api-v0.20.0"},"type":"image"}}}}}
  creationTimestamp: "2022-08-19T20:26:32Z"
  generation: 2
  name: olm-v0.20.0-api
  resourceVersion: "2296"
  uid: 4b87edff-5797-498e-ace8-955bbe04403e
spec:
  provisionerClassName: core-rukpak-io-plain
  template:
    spec:
      provisionerClassName: core-rukpak-io-plain
      source:
        image:
          ref: quay.io/tflannag/olm-plain-bundle:olm-api-v0.20.0
        type: image
status:
  activeBundle: olm-v0.20.0-api-bzzd42
  conditions:
  - lastTransitionTime: "2022-08-19T20:26:32Z"
    message: Successfully unpacked the olm-v0.20.0-api-bzzd42 Bundle
    reason: UnpackSuccessful
    status: "True"
    type: HasValidBundle
  - lastTransitionTime: "2022-08-19T20:27:36Z"
    message: Chart.yaml file is missing
    reason: ReadingContentFailed
    status: "True"
    type: InvalidBundleContent
  - lastTransitionTime: "2022-08-19T20:27:39Z"
    message: instantiated bundle olm-v0.20.0-api-bzzd42 successfully
    reason: InstallationSucceeded
    status: "True"
    type: Installed

We can see that there's a InvalidBundleContent status condition type being injected by the helm chart provisioner despite the unique plain provisioner ID being specified.

[timflannagan]

This is probably a blocker for the upcoming v0.9.0 release.

[timflannagan]

After looking into this some more, my best guess is this is an issue with our util package's predicate filtering and the helm chart provisioner just highlighted this issue. It seems like this it's only isolated to the BD controller(s), and we're correctly filtering these events out for all the bundle controllers in the stack.

[timflannagan]

Alright ended up tracking down the issue. I'll throw up a PR in a bit.