Avoid requeueing BundleDeployments that contain the wrong unique provisioner ID #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tl;dr was that we were requeueing BundleDeployment resources for both the helm/plain provisioners's BD controllers when encountered a bundle cache event. These changes update this logic to verify that the BundleDeployment that's managing the Bundle also specifies the unique provisioner ID that we are watching to avoid blindly requeueing any BD resource during bundle watch events. |
exdx
approved these changes
Aug 20, 2022
timflannagan
force-pushed
the
fix/provisioner-bundledeployment-requeue-logic
branch
from
ecfa869
to
365d18f
Compare
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
…isioner ID Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
deleted the
fix/provisioner-bundledeployment-requeue-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509