Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The detail of the order shown in the fee transaction is wrong #395

Open
maryarm opened this issue Nov 19, 2023 · 0 comments
Open

The detail of the order shown in the fee transaction is wrong #395

maryarm opened this issue Nov 19, 2023 · 0 comments

Comments

@maryarm
Copy link
Contributor

maryarm commented Nov 19, 2023

Describe the bug
Looking at the transaction detail, the order of maker and taker is not set correctly.

maryarm added a commit that referenced this issue Dec 16, 2023
fatemeh-i pushed a commit that referenced this issue Dec 26, 2023
…e system (#413)

* #395: add wallet type to history

* #412: change exchange transfer to have two transactions in each the system involved

* #412: a bit refactoring and make tests green again!

* #412: enabled IT tests with maven build

* #412: used kafka testcontainer to provide dynamic kafka port

* #412: add missed class!

---------

Co-authored-by: Peyman <marchosiax@gmail.com>
Co-authored-by: Benyamin <23664159+Benyamin001@users.noreply.github.com>
Co-authored-by: Peyman <peyman.sepehrad@gmail.com>
Marchosiax added a commit that referenced this issue Jan 27, 2024
…ne record (#418)

* #395: add wallet type to history

* #412: change exchange transfer to have two transactions in each the system involved

* #412: a bit refactoring and make tests green again!

* #412: enabled IT tests with maven build

* #412: used kafka testcontainer to provide dynamic kafka port

* #412: add missed class!

* #396: changed transaction history to return details of sender/receiver in one record

* #396: optimize imports

---------

Co-authored-by: Peyman <marchosiax@gmail.com>
Co-authored-by: Benyamin <23664159+Benyamin001@users.noreply.github.com>
Co-authored-by: Peyman <peyman.sepehrad@gmail.com>
fatemeh-i added a commit that referenced this issue Apr 9, 2024
* changed transaction history to return details of sender/receiver in one record (#418)

* #395: add wallet type to history

* #412: change exchange transfer to have two transactions in each the system involved

* #412: a bit refactoring and make tests green again!

* #412: enabled IT tests with maven build

* #412: used kafka testcontainer to provide dynamic kafka port

* #412: add missed class!

* #396: changed transaction history to return details of sender/receiver in one record

* #396: optimize imports

---------

Co-authored-by: Peyman <marchosiax@gmail.com>
Co-authored-by: Benyamin <23664159+Benyamin001@users.noreply.github.com>
Co-authored-by: Peyman <peyman.sepehrad@gmail.com>

* DB performance review (#426)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* Have automatic deployment for OTC profile (#428)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* try to change zone in LocalDateTime

* change all Date of assign service based n Tehran zone

* change address life time

* set external network for vault

* set client-id client-secret for chain-scanner modules

* change wallet-sync authorization

* change wallet module address  in otc profiles

* reset zone config in assigne addresses service

* add new workflow for otc profile to have automatic deployment on a github action

* add automatic deploy step to otc workflow

* agg publish job to one of build steps

* Just build needed modules in otc github action

* Just test needed modules in otc github action

* Just build and test needed modules and their deps  in otc github action

* Just build and test needed modules and their deps  in otc github action v2

* Just build and test needed modules and their deps  in otc github action v3

* add workflow for OP env about otc services

* test production workflow for otc services

* Update main-otc.yml (docker-compose -> docker compose)

* remove override config from docker-compose in otc main workflow

* Update main-otc.yml (rm build config from docker compose command)

* add  to otc.yml config file

* add TAG env to otc.yml config file

* run workflow

* fetch last images before creating containers

* fetch last images before creating containers

* organized run command to  multipleline

* organized run command to  multipleline

* organized run command to  multipleline

* change in setting env in github-action

* change operation tag in otc  github-action

* change reading  tag syntax in otc  github-action

* docker-compose -> docker compose

* change tagging syntax in otc  github-action

* set default value for TAG param

* set default value for TAG param

* commit otc compose file changes

* add pull step before upping containers

* add pull step before upping containers

* preparing to active on the  main branch

* Hot fix  the query syntax (#432)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* fix query syntax

---------

Co-authored-by: maryarm <45322329+maryarm@users.noreply.github.com>
Co-authored-by: Peyman <marchosiax@gmail.com>
Co-authored-by: Benyamin <23664159+Benyamin001@users.noreply.github.com>
Co-authored-by: Peyman <peyman.sepehrad@gmail.com>
fatemeh-i added a commit that referenced this issue May 25, 2024
…and their configuration (#440)

* changed transaction history to return details of sender/receiver in one record (#418)

* #395: add wallet type to history

* #412: change exchange transfer to have two transactions in each the system involved

* #412: a bit refactoring and make tests green again!

* #412: enabled IT tests with maven build

* #412: used kafka testcontainer to provide dynamic kafka port

* #412: add missed class!

* #396: changed transaction history to return details of sender/receiver in one record

* #396: optimize imports

---------

Co-authored-by: Peyman <marchosiax@gmail.com>
Co-authored-by: Benyamin <23664159+Benyamin001@users.noreply.github.com>
Co-authored-by: Peyman <peyman.sepehrad@gmail.com>

* DB performance review (#426)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* Have automatic deployment for OTC profile (#428)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* try to change zone in LocalDateTime

* change all Date of assign service based n Tehran zone

* change address life time

* set external network for vault

* set client-id client-secret for chain-scanner modules

* change wallet-sync authorization

* change wallet module address  in otc profiles

* reset zone config in assigne addresses service

* add new workflow for otc profile to have automatic deployment on a github action

* add automatic deploy step to otc workflow

* agg publish job to one of build steps

* Just build needed modules in otc github action

* Just test needed modules in otc github action

* Just build and test needed modules and their deps  in otc github action

* Just build and test needed modules and their deps  in otc github action v2

* Just build and test needed modules and their deps  in otc github action v3

* add workflow for OP env about otc services

* test production workflow for otc services

* Update main-otc.yml (docker-compose -> docker compose)

* remove override config from docker-compose in otc main workflow

* Update main-otc.yml (rm build config from docker compose command)

* add  to otc.yml config file

* add TAG env to otc.yml config file

* run workflow

* fetch last images before creating containers

* fetch last images before creating containers

* organized run command to  multipleline

* organized run command to  multipleline

* organized run command to  multipleline

* change in setting env in github-action

* change operation tag in otc  github-action

* change reading  tag syntax in otc  github-action

* docker-compose -> docker compose

* change tagging syntax in otc  github-action

* set default value for TAG param

* set default value for TAG param

* commit otc compose file changes

* add pull step before upping containers

* add pull step before upping containers

* preparing to active on the  main branch

* Hot fix  the query syntax (#432)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* fix query syntax

* set exp tome for assigned address

* rm batch config from bc-gateway module

* trying to setBackgroundAuth for internal services

* replace reactive Security context via direct auth solution and using core module

* propagate currency services

* propagate currency datas (wallet<->bc-gateway

* complete manual deposite service

* fix conflict

* disable checking type of destination in manual transfer

* disable checking type of destination in manual transfer (#435)

* Create destination wallet owner in manual transfer if it did not exist. (#436)

* disable checking type of destination in manual transfer

* Create destination wallet owner in manual transfer if it was not exist

* develop a github-action to support deployment for different partners and their configuration (#437)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* try to change zone in LocalDateTime

* change all Date of assign service based n Tehran zone

* change address life time

* set external network for vault

* set client-id client-secret for chain-scanner modules

* change wallet-sync authorization

* change wallet module address  in otc profiles

* reset zone config in assigne addresses service

* add new workflow for otc profile to have automatic deployment on a github action

* add automatic deploy step to otc workflow

* agg publish job to one of build steps

* Just build needed modules in otc github action

* Just test needed modules in otc github action

* Just build and test needed modules and their deps  in otc github action

* Just build and test needed modules and their deps  in otc github action v2

* Just build and test needed modules and their deps  in otc github action v3

* add workflow for OP env about otc services

* test production workflow for otc services

* Update main-otc.yml (docker-compose -> docker compose)

* remove override config from docker-compose in otc main workflow

* Update main-otc.yml (rm build config from docker compose command)

* add  to otc.yml config file

* add TAG env to otc.yml config file

* run workflow

* fetch last images before creating containers

* fetch last images before creating containers

* organized run command to  multipleline

* organized run command to  multipleline

* organized run command to  multipleline

* change in setting env in github-action

* change operation tag in otc  github-action

* change reading  tag syntax in otc  github-action

* docker-compose -> docker compose

* change tagging syntax in otc  github-action

* set default value for TAG param

* set default value for TAG param

* commit otc compose file changes

* add pull step before upping containers

* add pull step before upping containers

* preparing to active on the  main branch

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* support deployment for multiple partners using external private config

* handle reading private ssh keys in  secure mode

* change access-token access type

* change access-token access type

* test fetching access token correctly

* test fetching access token correctly

* change access token format

* fix conflict

* preprocess private key to convert a multiple line data to a single line data and postprocess it to have valid format

* preprocess private key to convert a multiple line data to a single line data and postprocess it to have valid format

* disable build step tmp to test speedly

* reset output section

* reset output section

* try to debug errors with fake data

* try to debug errors with fake data

* try to debug errors with fake data

* try to debug errors with fake data

* fix bug with adding id to the step

* restore mvn build step

* add user password data to partners config for handling sudo-permission command

* develop a github-action to support deployment for different psrtners and their configuration

* develop a github-action to support deployment for different psrtners and their configuration

* rename steps

* develop a github-action to support deployment for different partners and their configuration (PRD env) (#439)

* change tx history query to have better performance

* update trx security filter

* fix reference of currencies comparation ( object -> symbol)

* seprate withdraw categories based on steps, enable unlimited  report history

* add withdraw filed to tx history resp

* fix withdraw settelment filed to tx history resp

* expose chains information service

* change permission of getChainsInfo

* try to change zone in LocalDateTime

* change all Date of assign service based n Tehran zone

* change address life time

* set external network for vault

* set client-id client-secret for chain-scanner modules

* change wallet-sync authorization

* change wallet module address  in otc profiles

* reset zone config in assigne addresses service

* add new workflow for otc profile to have automatic deployment on a github action

* add automatic deploy step to otc workflow

* agg publish job to one of build steps

* Just build needed modules in otc github action

* Just test needed modules in otc github action

* Just build and test needed modules and their deps  in otc github action

* Just build and test needed modules and their deps  in otc github action v2

* Just build and test needed modules and their deps  in otc github action v3

* add workflow for OP env about otc services

* test production workflow for otc services

* Update main-otc.yml (docker-compose -> docker compose)

* remove override config from docker-compose in otc main workflow

* Update main-otc.yml (rm build config from docker compose command)

* add  to otc.yml config file

* add TAG env to otc.yml config file

* run workflow

* fetch last images before creating containers

* fetch last images before creating containers

* organized run command to  multipleline

* organized run command to  multipleline

* organized run command to  multipleline

* change in setting env in github-action

* change operation tag in otc  github-action

* change reading  tag syntax in otc  github-action

* docker-compose -> docker compose

* change tagging syntax in otc  github-action

* set default value for TAG param

* set default value for TAG param

* commit otc compose file changes

* add pull step before upping containers

* add pull step before upping containers

* preparing to active on the  main branch

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* try to support multiple partners indeployment( init)

* support deployment for multiple partners using external private config

* handle reading private ssh keys in  secure mode

* change access-token access type

* change access-token access type

* test fetching access token correctly

* test fetching access token correctly

* change access token format

* fix conflict

* preprocess private key to convert a multiple line data to a single line data and postprocess it to have valid format

* preprocess private key to convert a multiple line data to a single line data and postprocess it to have valid format

* disable build step tmp to test speedly

* reset output section

* reset output section

* try to debug errors with fake data

* try to debug errors with fake data

* try to debug errors with fake data

* try to debug errors with fake data

* fix bug with adding id to the step

* restore mvn build step

* add user password data to partners config for handling sudo-permission command

* develop a github-action to support deployment for different psrtners and their configuration

* develop a github-action to support deployment for different psrtners and their configuration

* rename steps

* have dynamic deployment for PRD env

---------

Co-authored-by: maryarm <45322329+maryarm@users.noreply.github.com>
Co-authored-by: Peyman <marchosiax@gmail.com>
Co-authored-by: Benyamin <23664159+Benyamin001@users.noreply.github.com>
Co-authored-by: Peyman <peyman.sepehrad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant