Skip to content

Commit

Permalink
Fix flickering test
Browse files Browse the repository at this point in the history
modules/storages/spec/services/storages/group_folder_properties_sync_service_spec.rb:735
could fail because the order of the users returned by database is not
deterministic, making the expected ACL list order incorrect.

By sorting by id, the order is assured to be deterministic.
  • Loading branch information
cbliard committed Sep 25, 2023
1 parent 9964592 commit 41f8bea
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def tokens_query(project:)
.where(oauth_client: @storage.oauth_client)
.where.not(id: @admin_tokens_query)
.includes(:user)
.order(:id)
# The user scope is required in all cases except one:
# when the project is public and non member has at least one storage permission
# then all non memebers should have access to the project folder
Expand Down

0 comments on commit 41f8bea

Please sign in to comment.