[#49116] Internal error occurs when invalid project is set to template

https://community.openproject.org/work_packages/49116
opf · Jul 13, 2023 · 8a68a67 · 8a68a67
1 parent dbbbb28
commit 8a68a67
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/app/controllers/projects/templated_controller.rb b/app/controllers/projects/templated_controller.rb
@@ -48,10 +48,15 @@ def change_templated_action(templated)
 
     if service_call.success?
       flash[:notice] = t(:notice_successful_update)
-      redirect_to project_settings_general_path(@project)
     else
-      @errors = service_call.errors
-      render template: 'projects/settings/general'
+      messages = [
+        t('activerecord.errors.template.header', model: Project.model_name.human, count: service_call.errors.count),
+        service_call.message
+      ]
+
+      flash[:error] = messages.join(". ")
     end
+
+    redirect_to project_settings_general_path(@project)
   end
 end