Merge pull request #14863 from opf/fix/43520-search-bar-focus

Fix #43520 Search bar doesn't have focus state and the first element on the list seams always selected
opf · Mar 8, 2024 · ab70d1f · ab70d1f
2 parents 42f2d56 + 8e371de
commit ab70d1f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/frontend/src/app/core/global_search/input/global-search-input.component.sass b/frontend/src/app/core/global_search/input/global-search-input.component.sass
@@ -59,6 +59,9 @@ $search-input-height: 30px
       background: transparent
       border-color: var(--header-item-font-color) !important
 
+      &:focus-within
+        @include spot-focus
+
     .ng-arrow-wrapper
       display: none
 
@@ -134,7 +137,7 @@ $search-input-height: 30px
         &.ng-option-marked
           background-color: var(--drop-down-hover-bg-color)
         &.ng-option-selected
-          background-color: var(--drop-down-selected-bg-color)
+          background-color: unset
 
   &--input
     // Fix position of the spinner

diff --git a/spec/features/search/search_spec.rb b/spec/features/search/search_spec.rb
@@ -251,6 +251,7 @@ def expect_range(param_a, param_b)
         context 'when submitting without autocomplete' do
           it 'loads the WP in full view' do
             global_search.search "##{work_package.id}"
+            global_search.expect_work_package_marked(work_package)
             global_search.submit_with_enter
 
             wp_page = Pages::FullWorkPackage.new(work_package)