Skip to content

Commit

Permalink
fix broken sprint wiki creation
Browse files Browse the repository at this point in the history
  • Loading branch information
machisuji authored and oliverguenther committed Jan 31, 2024
1 parent 355ce8d commit e56453f
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 3 deletions.
5 changes: 2 additions & 3 deletions modules/backlogs/app/models/sprint.rb
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,15 @@ def impediments(project)

private

def create_wiki_page(page_title)
def create_wiki_page(page_title, author: User.current)
template = project.wiki.find_page(Setting.plugin_openproject_backlogs['wiki_template'])
page_text = if template
"h1. #{name}\n\n#{template.text}"
else
"h1. #{name}"
end

page = project.wiki.pages.build(title: page_title)
page.build_content(text: page_text)
page = project.wiki.pages.build(title: page_title, text: page_text, author:)
page.save!
end
end
23 changes: 23 additions & 0 deletions modules/backlogs/spec/models/sprint_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -260,4 +260,27 @@
end
end
end

describe '#wiki_page' do
let(:wiki) { create :wiki, project: }
let(:wiki_page) { WikiPage.where(wiki:, title: sprint.wiki_page).first }
let(:user) { create :user }

before do
sprint.project = project
sprint.save!
end

subject do
login_as user

sprint.wiki_page
end

it 'creates a new wiki page if none is present' do
expect { subject }.not_to raise_error

expect(wiki_page.text).to start_with("h1. #{sprint.name}")
end
end
end

0 comments on commit e56453f

Please sign in to comment.