Fix font loading in storybook #11529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Lato and the icon font were not loading correctly since the CSS expects them to be available under a certain URL. This URL is available in the core app, but not storybook. This commit makes sure the assets load correctly in Storybook, giving us pretty icons and the right font.
|
Looking forward to reviewing this! There seems to be a problem with the pullpreview however; it says "succesfully deployed" but there's no link, and the action had an error associated with it. I've removed and added the label again, let's see... Update, 21h39: Again, error + "successfully deployed" + no link to deployment :/
|
|
I checked that branch out locally, and there it works: How can we fix the pullpreview? |
|
It's this issue: storybookjs/storybook#18686 I'll see if we can work around it. |
Storybook assets cannot currently be loaded by merging directories, so this fix makes sure files are loaded individually. storybookjs/storybook#18686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Lato and the icon font were not loading correctly since the CSS expects them to be available under a certain URL. This URL is available in the core app, but not storybook. This commit makes sure the assets load correctly in Storybook, giving us pretty icons and the right font.