Journalize project attributes #11741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbliard
force-pushed
the
implementation/45081-journalize-project-attributes-changes
branch
from
03d0093
to
5dfb6db
Compare
ulferts
reviewed
Dec 2, 2022
cbliard
force-pushed
the
implementation/45081-journalize-project-attributes-changes
branch
2 times, most recently
from
4a39d12
to
50874b7
Compare
ulferts
requested changes
Dec 5, 2022
There was a problem hiding this comment.
General structure is looking good, @cbliard and what I have added are either smaller things or points triggered by the PR but not originating in it. For the later, we'd have to decide if they are valid and if so, when to do them.
db/migrate/20221202130039_fill_project_journals_with_existing_data.rb
Outdated
Show resolved
Hide resolved
db/migrate/20221202130039_fill_project_journals_with_existing_data.rb
Outdated
Show resolved
Hide resolved
|
@ulferts it's available for review when you have time. |
cbliard
added a commit
that referenced
this pull request
Dec 5, 2022
In #11741 (comment) Jens suggested to remove `activity_type` and rely on `journalized_type` instead as there is a 1:1 relationship between them. `activity_type` was introduced to differentiate between different types of activity for the same journalized model (e.g. creation vs editing), but this field is not used in practice.
This was referenced Dec 5, 2022
cbliard
added a commit
that referenced
this pull request
Dec 6, 2022
In #11741 (comment) Jens suggested to remove `activity_type` and rely on `journalized_type` instead as there is a 1:1 relationship between them. `activity_type` was introduced to differentiate between different types of activity for the same journalized model (e.g. creation vs editing), but this field is not used in practice.
ulferts
requested changes
Dec 6, 2022
db/migrate/20221202130039_fill_project_journals_with_existing_data.rb
Outdated
Show resolved
Hide resolved
cbliard
force-pushed
the
implementation/45081-journalize-project-attributes-changes
branch
from
3f50ff5
to
ad45127
Compare
cbliard
force-pushed
the
implementation/45081-journalize-project-attributes-changes
branch
from
ad45127
to
2cc0a43
Compare
cbliard
deleted the
implementation/45081-journalize-project-attributes-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP #45081