Implementation/45801 api with subset representer #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to decorate work packages with historic attributes and meta information. #11783
…interpreted as null #11243
…ttributes_by_timestamp` #11783 (comment)
…tionRepresenter` #11783
…ugh eager-loading wrapper #11783
… work package representer #11783
…perties only when they are present #11783
…now` is queried because this is the default case when no timestamp is given #11783
…k package matches the query filters #11783
…iven Otherwise, there are not filters to match and this field is meaningless. #11783
…ngle object and multiple objects #11783
…filters_at_timestamps` #11783
…ith the query params #11783
…nged_attributes: true` for api requests #11783
which should be plural because there can be several filters in the query. #11783
… initializer as suggested in review: #11783 (comment)
…equested at which the work package does not exist #11783
The additional properties are already marked with `uncacheable: true`. Re-enabling caching for certain scenarios is a follow-up step: fiedl#4 #11783 (comment)
as requested in review by Jens Ulferts: #11783 (comment)
…801-api-with-subset-representer
fiedl
reviewed
Mar 1, 2023
|
|
||
| it_behaves_like 'transforms' do | ||
| let(:params) { { timestamps: "-1y, now" } } | ||
| let(:expected) { { timestamps: [Timestamp.new("P-1Y"), Timestamp.parse("P-0Y")] } } |
There was a problem hiding this comment.
Ah, this is why you delegated the Timestamp#hash method :) 👍
There was a problem hiding this comment.
I added it for the memoization where a timestamp is the hash key
I did not know that was necessary before stumbling over this. With it I can do
pry(main)> { Timestamp.now => 1}[Timestamp.now]
=> 1
Without it it would be
pry(main)> { Timestamp.now => 1}[Timestamp.now]
=> nil
… yet Those specs added in #9afa928 were accidentally deleted when merging
|
@fiedl I think I addressed or commented on all your remarks. Could you please take another look? |
|
Thanks, very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #11783 which in turn builds on #11678 and contains their commits.
The goal of this PR is to:
attributesByTimestampproperty of theWorkPackageresource rendered according to the prototypical readout in Baseline-comparison API #11783 (https://community.openproject.org/wp/46263)_linkssection.api/v3/work_packages?timestamps=2023-01-31T00:00:00Z,PT0S) is minimized. To that end, the eager loading wrapper needs to be adapted. (https://community.openproject.org/wp/46262)