WP Fields [4]: Two columns with label-on-top on mobile only for long text fields #12588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 3, 2023 12:19
This is one of two possible variants of column layouting for work package fields, where all field labels behave the same. Because we cannot rely on breakpoints for layouting, the layouting instead relies on the widths of the containers themselves. Closes https://community.openproject.org/projects/14/work_packages/47680/activity
This is a variant being tested out in the context of the following work package: https://community.openproject.org/projects/14/work_packages/47680/activity
|
LGTM, this can be merged. There are still known issues, notably:
But we said that we'd consider this a separate issue. |
oliverguenther
approved these changes
Jun 12, 2023
|
Code-wise, LGTM. I haven't done another visual inspections as this was part of the recent discussions |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has three layouts:
https://community.openproject.org/projects/openproject/work_packages/47680/activity