Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#47992] Support Project status changes when rendering project activity #12643

Merged
merged 1 commit into from
May 17, 2023
Merged

[#47992] Support Project status changes when rendering project activity #12643

merged 1 commit into from
May 17, 2023

Conversation

aaron-contreras
Copy link
Contributor

@aaron-contreras aaron-contreras commented May 15, 2023 •
edited
Loading

Adds rendering ability for project status code changes on activity pages

Work package: https://community.openproject.org/work_packages/47992

@aaron-contreras aaron-contreras force-pushed the implementation/47992-support-project-status-changes-when-rendering-project-activity branch from 77bdc3c to 986822e Compare May 15, 2023 19:57
@aaron-contreras aaron-contreras changed the title [#47992] Support project status changes when rendering project activity [#47992] Support Project Status changes when rendering project activity May 15, 2023
@aaron-contreras aaron-contreras changed the title [#47992] Support Project Status changes when rendering project activity [#47992] Support Project status changes when rendering project activity May 15, 2023
@aaron-contreras aaron-contreras marked this pull request as ready for review May 15, 2023 22:15
cbliard
cbliard approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@cbliard cbliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

There is only one assertion that got deleted and which you should restore before merging. Once done, feel free to merge it.

spec/features/activities/project_attributes_activity_spec.rb Show resolved Hide resolved
spec/lib/journal_formatter/project_status_code_spec.rb Show resolved Hide resolved
spec/lib/journal_formatter/project_status_code_spec.rb Show resolved Hide resolved
@aaron-contreras
Render Project status on activities
29cd716 
Adds a custom journal formatter in order to display the i18n'd
version of the status code by converting them into their key form
since the values received by the journal formatter are the integer
values stored in the database.
@aaron-contreras aaron-contreras force-pushed the implementation/47992-support-project-status-changes-when-rendering-project-activity branch from 986822e to 29cd716 Compare May 16, 2023 16:12
@cbliard cbliard merged commit b184c28 into dev May 17, 2023
11 checks passed
@cbliard cbliard deleted the implementation/47992-support-project-status-changes-when-rendering-project-activity branch May 17, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbliard cbliard cbliard approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@aaron-contreras @cbliard