Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing time entry constraints #12654

Merged
merged 6 commits into from
May 22, 2023
Merged

removing time entry constraints #12654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb80f1c
Update shared_contract_examples.rb
zencmp May 17, 2023
ae3d9a1
removing time entry comment constraint max 255 characters
zencmp May 17, 2023
717fd42
removing time entry comment constraint max 255 characters
zencmp May 17, 2023
32317c4
Merge branch 'dev' into dev
zencmp May 17, 2023
05d67a9
Merge branch 'dev' into dev
zencmp May 17, 2023
b410428
Merge branch 'dev' into dev
zencmp May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/apiv3/tags/time_entries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ description: |-
| Property | Description | Type | Constraints | Supported operations | Condition |
| :----------: | --------------------------------------------------------- | -------- | ---------------------------------------------------- | -------------------- | ----------------------------------------------------------- |
| id | Time entries' id | Integer | x > 0 | READ | |
| comment | A text provided by the user detailing the time entry | String | max 255 characters | READ / WRITE | |
| comment | A text provided by the user detailing the time entry | String | | READ / WRITE | |
| spentOn | The date the expenditure is booked for | Date | | READ / WRITE | |
| hours | The time quantifying the expenditure | Time | | READ / WRITE | |
| createdAt | The time the time entry was created | DateTime | | READ | |
Expand Down
1 change: 0 additions & 1 deletion modules/costs/app/models/time_entry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class TimeEntry < ApplicationRecord

validates_presence_of :user_id, :activity_id, :project_id, :hours, :spent_on
validates_numericality_of :hours, allow_nil: true, message: :invalid
validates_length_of :comments, maximum: 255, allow_nil: true

scope :on_work_packages, ->(work_packages) { where(work_package_id: work_packages) }

Expand Down
8 changes: 0 additions & 8 deletions modules/costs/spec/contracts/time_entries/shared_contract_examples.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,14 +210,6 @@ def expect_valid(valid, symbols = {})
end
end

context 'when comment is longer than 255' do
let(:time_entry_comments) { "a" * 256 }

it 'is invalid' do
expect_valid(false, comments: %i(too_long))
end
end

context 'when comment is nil' do
let(:time_entry_comments) { nil }

Expand Down
Loading