Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[50749] Contrast issues #14185

Merged
merged 26 commits into from
Nov 30, 2023
Merged

[50749] Contrast issues #14185

merged 26 commits into from
Nov 30, 2023

Conversation

bsatarnejad
Copy link
Contributor

@bsatarnejad bsatarnejad commented Nov 20, 2023

@bsatarnejad bsatarnejad marked this pull request as ready for review November 21, 2023 14:26
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bsatarnejad

Looks good overall. I found some place that still don't have enough contrast:

  • In the files tab (To add a link, see or upload files...) the text is too bright. (contrast 2,8:1)
Bildschirmfoto 2023-11-24 um 09 26 48
  • There are multiple places where we reached a ratio of 5:1 which is not sufficient for wcag AAA. I am not sure at the moment whether we aim for AA or AAA. Please double check that. For AAA we would need a ratio of 7:1. Examples are the sidebar headlines, locked users in the administration, filtered out parents in the WP table, the placeholder in date modal or greyed out options in the configuration dropdown of the WP table.
Bildschirmfoto 2023-11-24 um 09 25 46 Bildschirmfoto 2023-11-24 um 09 24 42 Bildschirmfoto 2023-11-24 um 09 35 54

frontend/src/global_styles/content/_project_status.sass Outdated Show resolved Hide resolved
@bsatarnejad
Copy link
Contributor Author

bsatarnejad commented Nov 30, 2023

Hi @bsatarnejad

Looks good overall. I found some place that still don't have enough contrast:

  • In the files tab (To add a link, see or upload files...) the text is too bright. (contrast 2,8:1)
Bildschirmfoto 2023-11-24 um 09 26 48 [ ] There are multiple places where we reached a ratio of 5:1 which is not sufficient for wcag AAA. I am not sure at the moment whether we aim for AA or AAA. Please double check that. For AAA we would need a ratio of 7:1. Examples are the sidebar headlines, locked users in the administration, filtered out parents in the WP table, the placeholder in date modal or greyed out options in the configuration dropdown of the WP table.

Bildschirmfoto 2023-11-24 um 09 25 46 Bildschirmfoto 2023-11-24 um 09 24 42 Bildschirmfoto 2023-11-24 um 09 35 54

As we discussed, We need to pass AA level, so for now a ratio of 5:1 is sufficient.

@HDinger HDinger merged commit 8b87c20 into dev Nov 30, 2023
7 checks passed
@HDinger HDinger deleted the 50749-contrast-issues branch November 30, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants