-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[50749] Contrast issues #14185
Merged
Merged
[50749] Contrast issues #14185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsatarnejad
force-pushed
the
50749-contrast-issues
branch
from
November 21, 2023 13:05
7d6cd95
to
8f95bfd
Compare
… 50749-contrast-issues
HDinger
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bsatarnejad
Looks good overall. I found some place that still don't have enough contrast:
- In the files tab (
To add a link, see or upload files...
) the text is too bright. (contrast 2,8:1)
- There are multiple places where we reached a ratio of 5:1 which is not sufficient for wcag AAA. I am not sure at the moment whether we aim for AA or AAA. Please double check that. For AAA we would need a ratio of 7:1. Examples are the sidebar headlines, locked users in the administration, filtered out parents in the WP table, the placeholder in date modal or greyed out options in the configuration dropdown of the WP table.
As we discussed, We need to pass AA level, so for now a ratio of 5:1 is sufficient. |
HDinger
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/projects/openproject/work_packages/50749/activity