Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DangerZone for storage deletion in administration #14243

Merged
merged 1 commit into from Nov 28, 2023
Merged

Added DangerZone for storage deletion in administration #14243

merged 1 commit into from Nov 28, 2023

Conversation

apfohl
Copy link
Member

@apfohl apfohl commented Nov 24, 2023 •
edited

https://community.openproject.org/projects/openproject/work_packages/50609/activity

This PR adds the Danger Zone to confirm a file storage deletion from the Administration of File Storages.

  • Triggered by clicking the delete button on the File Storage Edit page.
  • Upon entering the correct name of the storage that should be deleted, the "Delete" button gets active.
  • After successful deletion, the list of remaining storages is show.
  • Cancelling the Danger Zone leads back to the list of storages.

@apfohl apfohl force-pushed the implementation/50609-add-danger-zone-for-storage-delete branch from 804ca1d to e8fc061 Compare November 27, 2023 10:17
@apfohl apfohl force-pushed the implementation/50609-add-danger-zone-for-storage-delete branch 2 times, most recently from 1d49c7f to 12ce930 Compare November 28, 2023 09:19
@apfohl apfohl force-pushed the implementation/50609-add-danger-zone-for-storage-delete branch from 12ce930 to a92ae5e Compare November 28, 2023 09:19
@apfohl apfohl requested a review from ba1ash November 28, 2023 09:20
ba1ash
ba1ash approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ba1ash ba1ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@apfohl apfohl merged commit 2369067 into dev Nov 28, 2023
9 checks passed
@apfohl apfohl deleted the implementation/50609-add-danger-zone-for-storage-delete branch November 28, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ba1ash ba1ash ba1ash approved these changes

@wielinde wielinde Awaiting requested review from wielinde

@akabiru akabiru Awaiting requested review from akabiru

Assignees
No one assigned
Labels
feature needs review
Milestone
No milestone
3 participants
@apfohl @wielinde @ba1ash