Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code maintenance/53729 remove project custom field mapping and the projects aac patch #15498

Merged
merged 38 commits into from
Jun 20, 2024
Merged

Code maintenance/53729 remove project custom field mapping and the projects aac patch #15498

merged 38 commits into from
Jun 20, 2024

Commits on Jun 17, 2024

  1. [#53729] Remove project_custom_field_mapping and the projects aac patch 

    https://community.openproject.org/work_packages/53729
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    81a44b2 View commit details
    Browse the repository at this point in the history

  2. Use previously_new_record? in the available_custom_fields of the aac … 

    …project patch.
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d6b5030 View commit details
    Browse the repository at this point in the history

  3. Use global flag cache keys

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c2cd7c7 View commit details
    Browse the repository at this point in the history

  4. Restrict custom value cache key to section

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1b5bba1 View commit details
    Browse the repository at this point in the history

  5. Change available_custom_fields query

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    56a1445 View commit details
    Browse the repository at this point in the history

  6. Remove previously_new_record? condition from Project#available_custom… 

    …_fields
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0f19b7c View commit details
    Browse the repository at this point in the history

  7. Use the global modifier in the custom values cache key

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    377bb80 View commit details
    Browse the repository at this point in the history

  8. Change the custom field validation to allow defining fields to validate.

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e5f9455 View commit details
    Browse the repository at this point in the history

  9. Undo name change

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2a21cb0 View commit details
    Browse the repository at this point in the history

  10. Introduce custom_field_values_to_validate method to control section b… 

    …ased validation
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0b30599 View commit details
    Browse the repository at this point in the history

  11. Try moving the aac validation into the contracts

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    03c4542 View commit details
    Browse the repository at this point in the history

  12. Revert "Try moving the aac validation into the contracts" 

    This reverts commit 1db410c.
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9ae205a View commit details
    Browse the repository at this point in the history

  13. Move disable_custom_fields_with_empty_values to the NewProjectService… 

    … concern.
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0a6d390 View commit details
    Browse the repository at this point in the history

  14. Add specs for moving callbacks from AAC patch to the contract.

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    69b146e View commit details
    Browse the repository at this point in the history

  15. Update the Projects::CopyService to execute the after_perform super f… 

    …irst
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d839f83 View commit details
    Browse the repository at this point in the history

  16. Move AAC patch parts to the project services

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ae717e7 View commit details
    Browse the repository at this point in the history

  17. Remove set_query_available_custom_fields_to_project_level after valid… 

    …ate hook from the AAC patch
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    cadf654 View commit details
    Browse the repository at this point in the history

  18. Use the after_perform hook to reset global query on the Projects serv… 

    …ices
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2b85ab9 View commit details
    Browse the repository at this point in the history

  19. Move reject_section_scoped_validation to the Projects::CreateContract

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a036727 View commit details
    Browse the repository at this point in the history

  20. Move section based validation check to the Projects::CreateService

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3640a74 View commit details
    Browse the repository at this point in the history

  21. Move specs for activating custom fields with default values to Projec… 

    …ts::CreateContract
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2fd2fb8 View commit details
    Browse the repository at this point in the history

  22. Fix copy spec setup.

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    152b26a View commit details
    Browse the repository at this point in the history

  23. Move reset_section_scoped_validations method to Projects::UpdateService

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b392af0 View commit details
    Browse the repository at this point in the history

  24. Remove accidental comments

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    96f7ab5 View commit details
    Browse the repository at this point in the history

  25. Fix specs for removing _limi_custom_fields_validation_to_section_id i… 

    …n Projects::UpdateContract
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8cf0732 View commit details
    Browse the repository at this point in the history

  26. Move the set_query_available_custom_fields_to_global_level to the Pro… 

    …jects::UpdateContract
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    86a01bf View commit details
    Browse the repository at this point in the history

  27. Try removing unused callbacks

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ed36d46 View commit details
    Browse the repository at this point in the history

  28. Update Project service comments.

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d8d45d2 View commit details
    Browse the repository at this point in the history

  29. Remove the for_custom_field_accessor patch only

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b589dcc View commit details
    Browse the repository at this point in the history

  30. Remove aac patch custom_field_values= method

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0e01fb4 View commit details
    Browse the repository at this point in the history

  31. Remove more additional methods from the aac patch

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1e43ab7 View commit details
    Browse the repository at this point in the history

  32. Create Projects::CustomField and Projects::WorkPackageCustomFields co… 

    …ncerns.
    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2f42f97 View commit details
    Browse the repository at this point in the history

  33. Move project hierarchy related code to the Projects::Hierarchy concern

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6b3bd43 View commit details
    Browse the repository at this point in the history

  34. Move more hierarchy related methods to Projects::Hierarchy

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    03ef711 View commit details
    Browse the repository at this point in the history

  35. Create Projects::Types and Projects::Versions concerns.

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    736cce6 View commit details
    Browse the repository at this point in the history

  36. Refactor and cache available_custom_fields methods

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    02d890b View commit details
    Browse the repository at this point in the history

  37. Improve cache key method comment

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4c2f5f3 View commit details
    Browse the repository at this point in the history

  38. Add all_available_custom_fields method comment.

    @dombesz
    dombesz committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    aa7c2ee View commit details
    Browse the repository at this point in the history