Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Private Sprockets Fork #2128

Merged
merged 1 commit into from Nov 3, 2014
Merged

Use Private Sprockets Fork #2128

merged 1 commit into from Nov 3, 2014

Conversation

tessi
Copy link
Collaborator

@tessi tessi commented Nov 2, 2014

The sprockets maintainer yanked the sprockets version we use from rubygems.

selection_187

It happened that I had the specific sprockets version at my harddrive.

We really should update sprockets, but until this happens, the fork can
be used.

It seems other people have this problem too ->https://community.openproject.org/topics/1348?page=1&per_page=200

The sprockets maintainer yanked the sprockets version we
use from rubygems. It happened that I had the specific sprockets version
at my harddrive.

We really should update sprockets, but until this happens, the fork can
be used.
@TeatroIO
Copy link

TeatroIO commented Nov 2, 2014

I've prepared a stage. Click to open.

@myabc
Copy link
Contributor

myabc commented Nov 2, 2014

@tessi the sooner we get off this shit, the better.

@ulferts
Copy link
Contributor

ulferts commented Nov 3, 2014

@tessi, this is against the dev branch, we will probably have to get this against release/4.0 as well.

ulferts added a commit that referenced this pull request Nov 3, 2014
@ulferts ulferts merged commit 2d4796f into dev Nov 3, 2014
@ulferts ulferts deleted the fix/sprockets_backports branch November 3, 2014 11:10
@kgalli
Copy link
Contributor

kgalli commented Nov 3, 2014

@tessi maybe you could apply the security patch to this repo so we do not have to fix this version in the OpenProject core? see #2116

@astehmari
Copy link

Hi @tessi and all,

Newbie here, i've been trying to install Openproject on by Debian 8 VPS and i've run into this:


Bundler could not find compatible versions for gem "sprockets":
In Gemfile:
sprockets-rails (>= 0) ruby depends on
sprockets (= 2.2.2.backport2) ruby
sprockets (>= 0) ruby
Could not find gem 'sprockets (= 2.2.2.backport2) ruby', which is required by gem 'sprockets-rails (>= 0) ruby', in any of the sources.


I see that "The sprockets maintainer yanked the sprockets version we use from rubygems." but i've just downloaded the latest version of Openproject, is this problem still alive, is there a fix? I found one old download for the 2.2.2 but that seems to be faulty.

My system:
Kernel and CPU: Linux 3.2.0-4-amd64 on x86_64
Processor information: Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 2 cores
OS Description: Debian GNU/Linux 8.1 (jessie)
Ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-linux]

Please advise asap, much appreciated.
Astehmari

@tessi
Copy link
Collaborator Author

tessi commented Sep 1, 2015

Hi Astehmari,

I got that exact same error a year ago and, therefore, forked sprockets and re-introduced that sprockets version. I noticed that the @opf/developers (one of the core people - can't remember who it was right now) forked my fork. So maybe something changed in the recent OpenProject versions.

If you use my Sprockets fork in the Gemfile things should probably work fine, but I guess the OpenProject team has something in mind with their change. So it's probably a bug, that should get fixed.

@tessi
Copy link
Collaborator Author

tessi commented Sep 1, 2015

(and I want to stress that is is a very good idea not to use my fork and, instead, migrate OpenProject to one of the officially maintained sprockets versions which enjoys the luxury of security fixes)

@oliverguenther
Copy link
Member

Hi @astehmari , you're probably on a 4.2 release. Please see this PR that relies on a fork of the OP developer for sprockets on 4.2: #3399

@tessi
Copy link
Collaborator Author

tessi commented Sep 1, 2015

@oliverguenther 👍 thanks for the late reply :)

@astehmari
Copy link

Hi Philipp & Oliver,

Thanks for getting back to me on this. I'm quite new to administering this
matter, can i get an answer in plain language. Is this the resolution?


The 2_2_2_backport2 at
https://github.com/tessi/sprockets/tree/2_2_2_backport2 actually has the
version 2.2.3 leading to an invalid dependency with sprockets-rails.

This fix relies on a clone of the repo to fix the branch structure.

What should i do?
Astehmari

On 1 September 2015 at 23:13, Philipp Tessenow notifications@github.com
wrote:

@oliverguenther https://github.com/oliverguenther [image: 👍] thanks
for the late reply :)


Reply to this email directly or view it on GitHub
#2128 (comment).

Astehmari Batekun
Principal Teacher
Schools Of Unified Learning (SOUL)
www.mathsdance.co.uk
www.unifiedknowledge.org
www.youtube.com/unifiedknowledge
@astehmari https://twitter.com/astehmari

Executive Member
Abundance Centres (UK)
www.abundancecentre.org

T: 020 8144 1720
M: 075 3003 8547

@oliverguenther
Copy link
Member

Hi Astehmari,

sure, let's step back a bit to find out why this is happening to you. Did you install OP manually using the guide, or a packaged installation?

@astehmari
Copy link

Hi Oliver, Yes these are the instructions i am working through. The
problem appears at the "[openproject@all] bundle install" instruction.

On 2 September 2015 at 06:53, Oliver Günther notifications@github.com
wrote:

Hi Astehmari,

sure, let's step back a bit to find out why this is happening to you. Did
you install OP manually using the guide
https://github.com/opf/openproject/blob/release/4.2/doc/operation_guides/manual/installation-guide.md,
or a packaged installation?


Reply to this email directly or view it on GitHub
#2128 (comment).

@astehmari
Copy link

Hi everyone,

Any news on this? I've been trying to showcase and explore Openproject
with several project teams that i am working with and this is
embarrassing. Should we be looking to another project management software
solution?

Astehmari

On 2 September 2015 at 09:19, Astehmari Batekun astehmari@gmail.com wrote:

Hi Oliver, Yes these are the instructions i am working through. The
problem appears at the "[openproject@all] bundle install" instruction.

On 2 September 2015 at 06:53, Oliver Günther notifications@github.com
wrote:

Hi Astehmari,

sure, let's step back a bit to find out why this is happening to you. Did
you install OP manually using the guide
https://github.com/opf/openproject/blob/release/4.2/doc/operation_guides/manual/installation-guide.md,
or a packaged installation?


Reply to this email directly or view it on GitHub
#2128 (comment).

@oliverguenther
Copy link
Member

Hi @astehmari ,

sorry for the delay. We're currently working very hard on the latest changes for a major upcoming release (5.0) and I've overlooked your last comment.

That being said, I cannot reproduce your error on the current release/4.2 branch. Please ensure that you are actually on the correct and updated branch (the fix for this problem has been merged a little less than two weeks ago).

You should have these entries in your Gemfile (l. 104ff.). Please report if the specified versions do not match these below.

gem 'sprockets',       git: 'https://github.com/finnlabs/sprockets.git',
                                branch: '2_2_3_backport2'
gem 'sprockets-rails', git: 'https://github.com/finnlabs/sprockets-rails.git',
                                   branch: 'backport_w_2_2_3_sprockets'`

I'd also like to invite you to the public gitter channel, in which we may exchange information more quickly and with more members to join in:

https://gitter.im/opf/openproject

@astehmari
Copy link

Hi Oliver and all,

Thanks for your assistance and advise. That socket issue has now been
passed. The installation has since be quite clear there is just this:


You are currently validating against Phusion Passenger 5.0.16, located in:

/home/openproject/.rbenv/versions/2.1.6/lib/ruby/gems/2.1.0/gems/passenger-5.0.16/bin/passenger

Besides this Passenger installation, the following other
Passenger installations have also been detected:

 /home/openproject/.rbenv/shims/passenger

Please uninstall these other Passenger installations to avoid

confusion or conflicts.

How should i remove /home/openproject/.rbenv/shims/passenger?

I think this is the final issue. Apache is viewing the correct place, just
that is shows a list of docs/folders in the public folder (this article
helped: https://community.openproject.org/topics/3047).

Please advise on removing passenger asap, thanks.

Astehmari

On 3 September 2015 at 19:54, Oliver Günther notifications@github.com
wrote:

Hi @astehmari https://github.com/astehmari ,

sorry for the delay. We're currently working very hard on the latest
changes for a major upcoming release (5.0
https://community.openproject.org/work_packages/18820) and I've
overlooked your last comment.

That being said, I cannot reproduce your error on the current release/4.2
branch. Please ensure that you are actually on the correct and updated
branch (the fix for this problem has been merged a little less than two
weeks ago).

You should have these entries in your Gemfile (l. 104ff.). Please report
if the specified versions do not match these below.

gem 'sprockets', git: 'https://github.com/finnlabs/sprockets.git',
branch: '2_2_3_backport2'
gem 'sprockets-rails', git: 'https://github.com/finnlabs/sprockets-rails.git',
branch: 'backport_w_2_2_3_sprockets'`

I'd also like to invite you to the public gitter channel, in which we may
exchange information more quickly and with more members to join in:

https://gitter.im/opf/openproject


Reply to this email directly or view it on GitHub
#2128 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants