Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18714] Pin select2 3.5.2 [Backport to 4.2] #3205

Merged
merged 1 commit into from Jul 3, 2015

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Jul 3, 2015

Backports #3120 changes to release/4.2

This will pin the dependency to select2 to 3.5.2

I noticed it while doing a quick reinstall of all the node_modules and bower deps.

@TeatroIO
Copy link

TeatroIO commented Jul 3, 2015

I've prepared a stage to preview changes. Open stage or view logs.

@myabc myabc added this to the 4.2 milestone Jul 3, 2015
@myabc myabc added the bugfix label Jul 3, 2015
@myabc myabc mentioned this pull request Jul 3, 2015
@myabc
Copy link
Contributor Author

myabc commented Jul 3, 2015

@ulferts @NobodysNightmare as @floriank mentioned in #3120, this should go into release/4.2, release/4.3 and feature/rails4. bower install behaviour differs depending on whether there is an existing bower_components directory. In the case of our Rails 4 QA instances, set-up from scratch, the wrong version of select2 has been installed - causing quite a few UI issues (and I'm assuming, blocking proper review of the feature/rails4 branch).

@floriank
Copy link
Contributor

floriank commented Jul 3, 2015

After a quick checkout this should be okay to merge, let's wait for travis.

floriank added a commit that referenced this pull request Jul 3, 2015
[18714] Pin select2 3.5.2 [Backport to 4.2]
@floriank floriank merged commit 88b708b into opf:release/4.2 Jul 3, 2015
@myabc myabc deleted the fix/pin-select-version-backport branch July 3, 2015 14:36
@NobodysNightmare NobodysNightmare removed their assignment Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants