Deprecate bower and replace with node-only deps #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
housekeeping/deprecate-bower
branch
3 times, most recently
from
9fcb202
to
0052ee0
Compare
It requires some internal version of jQuery that causes mayhem.
It is not available on npm and migrating it is non-straightforward.
oliverguenther
force-pushed
the
housekeeping/deprecate-bower
branch
from
0052ee0
to
fd0c4f8
Compare
oliverguenther
force-pushed
the
housekeeping/deprecate-bower
branch
from
fd0c4f8
to
0fa771f
Compare
|
LGTM. What could possibly go wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to get rid of bower and move all assets to the package.json. We already no longer have a strict separation between the original testing and frontend dependencies, thus two dependencies managers make no sense.
The only downside to this migration is at.js and select2, both which are not yet available on npm on the older versions. We have two options in the scope of this PR:
1.) Vendor these versions until we upgrade
2.) Upgrade the versions directly. I went down that path but there are some inconsistencies in select2, which is why I diverted back to option 1)