[27406] Rename responsible to accountable

app/controllers/projects_controller.rb

@@ -40,7 +40,6 @@ class ProjectsController < ApplicationController
   before_action :require_admin, only: [:archive, :unarchive, :destroy, :destroy_info]
   before_action :jump_to_project_menu_item, only: :show
   before_action :load_project_settings, only: :settings
-  before_action :determine_base
 
   accept_key_auth :index, :level_list, :show, :create, :update, :destroy
 
@@ -303,14 +302,6 @@ def filter_projects_by_permission(projects)
 
   protected
 
-  def determine_base
-    @base = if params[:project_type_id]
-              ProjectType.find(params[:project_type_id]).projects
-            else
-              Project
-            end
-  end
-
   def set_sorting(query)
     orders = query.orders.select(&:valid?).map { |o| [o.attribute.to_s, o.direction.to_s] }
 

app/helpers/projects_helper.rb

@@ -120,10 +120,6 @@ def format_version_sharing(sharing)
     l("label_version_sharing_#{sharing}")
   end
 
-  def options_for_project_types
-    ProjectType.all.map { |t| [t.name, t.id] }
-  end
-
   def filter_set?
     params[:filters].present?
   end

app/models/permitted_params.rb

@@ -130,18 +130,10 @@ def member
     params.require(:member).permit(*self.class.permitted_attributes[:member])
   end
 
-  def project_type
-    params.require(:project_type).permit(*self.class.permitted_attributes[:project_type])
-  end
-
   def projects_type_ids
     params.require(:project).require(:type_ids).map(&:to_i).select { |x| x > 0 }
   end
 
-  def project_type_move
-    params.require(:project_type).permit(*self.class.permitted_attributes[:move_to])
-  end
-
   def query
     # there is a weird bug in strong_parameters gem which makes the permit call
     # on the sort_criteria pattern return the sort_criteria-hash contents AND

app/models/project.rb

@@ -179,12 +179,6 @@ class Project < ActiveRecord::Base
   scope :visible, ->(user = User.current) { Project.visible_by(user) }
   scope :newest, -> { order(created_on: :desc) }
 
-  # timelines stuff
-
-  belongs_to :project_type, class_name: '::ProjectType'
-
-  belongs_to :responsible,  class_name: 'User'
-
   def visible?(user = User.current)
     self.active? and (self.is_public? or user.admin? or user.member_of?(self))
   end

app/models/type/attributes.rb

@@ -143,7 +143,7 @@ def attr_translate(name)
         I18n.t('label_date')
       else
         key = attr_i18n_key(name)
-        I18n.t("activerecord.attributes.work_package.#{key}", default: '')
+        I18n.t("activerecord.attributes.work_package.#{key}", fallback: false, default: '')
           .presence || I18n.t("attributes.#{key}")
       end
     end

app/models/user.rb

@@ -67,9 +67,6 @@ class User < Principal
   has_many :responsible_for_issues, foreign_key: 'responsible_id',
                                     class_name: 'WorkPackage',
                                     dependent: :nullify
-  has_many :responsible_for_projects, foreign_key: 'responsible_id',
-                                      class_name: 'Project',
-                                      dependent: :nullify
   has_many :watches, class_name: 'Watcher',
                      dependent: :delete_all
   has_many :changesets, dependent: :nullify

app/seeders/basic_data/workflow_seeder.rb

@@ -53,22 +53,6 @@ def seed_data!
                                                  is_in_roadmap: true,
                                                  is_milestone: false)
 
-          # Adds the standard type to all existing projects
-          #
-          # As this seed might be executed on an existing database, there might be projects
-          # that do not have the default type yet.
-
-          condition = "NOT EXISTS
-                         (SELECT * from projects_types
-                          WHERE projects.id = projects_types.project_id
-                          AND projects_types.type_id = #{standard_type.id})"
-
-          projects_without_standard_type = Project.where(condition).all
-
-          projects_without_standard_type.each do |project|
-            project.types << standard_type
-          end
-
           [WorkPackage, Journal::WorkPackageJournal].each do |klass|
             klass.where(type_id: nil).update_all(type_id: standard_type.id)
           end

app/seeders/basic_data_seeder.rb

@@ -35,7 +35,6 @@ def data_seeder_classes
       BasicData::ColorSeeder,
       BasicData::WorkflowSeeder,
       BasicData::PrioritySeeder,
-      BasicData::ProjectTypeSeeder,
       BasicData::SettingSeeder
     ]
   end