Bump mimemagic to non-yanked version #9124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliverguenther this should also be put into release/11.2, then. Can we put it into the release branch to then merge it back? |
oliverguenther
force-pushed
the
bump/mimemagic
branch
from
f149ad4
to
1a32db9
Compare
oliverguenther
added a commit
that referenced
this pull request
Mar 25, 2021
The upstream mimemagic now is MIT again, but requires a system dependency on shared-mime-info which we don't care about as we are GPL ourselves. #9124
oliverguenther
added a commit
that referenced
this pull request
Mar 25, 2021
The upstream mimemagic now is MIT again, but requires a system dependency on shared-mime-info which we don't care about as we are GPL ourselves. #9124
oliverguenther
added a commit
that referenced
this pull request
Mar 25, 2021
The upstream mimemagic now is MIT again, but requires a system dependency on shared-mime-info which we don't care about as we are GPL ourselves. #9124
wielinde
pushed a commit
that referenced
this pull request
Mar 26, 2021
The upstream mimemagic now is MIT again, but requires a system dependency on shared-mime-info which we don't care about as we are GPL ourselves. #9124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also
mimemagicrb/mimemagic#98
rails/rails#41750
The gem was incorrectly published as MIT-licensed despite shipping with a GPL file from freedesktop to generate Ruby from. The older versions were yanked and a new one exists that is GPL licensed.
This problem will still go on for some while as the upstream MIT projects using it (rails, Marcel) can no longer use mimemagic now due to incompatible licenses