Recurrent card : add a control in the code to forbid negative number …

…for "minutes to remind before task" (#5483) Signed-off-by: vlo-rte <valerie.longa@rte-france.com>
opfab · Dec 5, 2023 · 427c16f · 427c16f
1 parent 5d9de43
commit 427c16f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/services/cards-consultation/src/test/java/org/opfab/cards/consultation/TestUtilities.java b/services/cards-consultation/src/test/java/org/opfab/cards/consultation/TestUtilities.java
@@ -313,6 +313,8 @@ public static EasyRandom instantiateEasyRandom() {
                 .scanClasspathForConcreteTypes(true)
                 .overrideDefaultInitialization(false)
                 .ignoreRandomizationErrors(true)
+                .excludeField(predicate->predicate.getName().equals("durationInMinutes"))
+                .excludeField(predicate->predicate.getName().equals("secondsBeforeTimeSpanForReminder"))
                 .excludeField(predicate->predicate.getName().equals("usersAcks"))
                 .excludeField(predicate->predicate.getName().equals("usersReads"))
                 .excludeField(predicate->predicate.getName().equals("entitiesAcks"));

diff --git a/services/cards-publication/src/main/modeling/swagger.yaml b/services/cards-publication/src/main/modeling/swagger.yaml
@@ -191,6 +191,7 @@ definitions:
       durationInMinutes:
         description: Duration in minutes of the event
         type: integer
+        minimum: 0
   TimeSpan:
     type: object
     description: An object to define a business time span
@@ -229,6 +230,7 @@ definitions:
       durationInMinutes:
         description: Duration in minutes of the event
         type: integer
+        minimum: 0
     required:
       - hoursAndMinutes
   HoursAndMinutes:
@@ -404,6 +406,7 @@ definitions:
         description: Contains projection ex. 'EPSG:4326'
       secondsBeforeTimeSpanForReminder:
         type: integer
+        minimum: 0
       toNotify:
         type: boolean
         description: Is false if the card must not be displayed in the feed and in monitoring screen