Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in id fields : cypress tests and/or forbid characters #4339

Closed
vlo-rte opened this issue Mar 21, 2023 · 1 comment · Fixed by #4485
Closed

Special characters in id fields : cypress tests and/or forbid characters #4339

vlo-rte opened this issue Mar 21, 2023 · 1 comment · Fixed by #4485
Assignees
Labels
Enhancement New feature

Comments

@vlo-rte
Copy link
Contributor

vlo-rte commented Mar 21, 2023

Related to this issue : #4336
Add a test (or use an existing test) to put a space character in the processInstanceId field and try to open the card (be careful, before the update for the bug #4336, the card could be displayed for 1 second (approximatively) and then it disappeared and it is replaced by the spinner endlessly, so we have to take into account this point in the test).

Take into account other fields that could be a problem, like stateId for example.

The following characters are used in production
« _ »
« : »
« -
« »
« ( »
« ) »
« ; »
« . »

  #, ? et / are not used so we should prohibit them

---> To be confirmed

@vlo-rte vlo-rte added the Draft Issue not totally defined label Mar 21, 2023
@freddidierRTE
Copy link
Contributor

freddidierRTE commented Apr 19, 2023

The issue content is :
Do not authorize anymore #, ? and / in process and processInstanceId fields of the cards.

The control is to be done in the card publication service

To test , use only unit tests (no karate tests) , see for example in services/cards-publication/src/test/java/org/opfab/cards/publication/services/CardProcessServiceShould.java

void GIVEN_a_card_with_an_unexisting_state_WHEN_sending_card_THEN_card_is_rejected() {

@freddidierRTE freddidierRTE added Enhancement New feature and removed Draft Issue not totally defined labels Apr 19, 2023
@quinarygio quinarygio self-assigned this May 10, 2023
quinarygio added a commit that referenced this issue May 10, 2023
Signed-off-by: Giovanni Ferrari <giovanni.ferrari@soft.it>
quinarygio added a commit that referenced this issue May 11, 2023
Signed-off-by: Giovanni Ferrari <giovanni.ferrari@soft.it>
quinarygio added a commit that referenced this issue May 12, 2023
Signed-off-by: Giovanni Ferrari <giovanni.ferrari@soft.it>
freddidierRTE pushed a commit that referenced this issue May 12, 2023
Signed-off-by: Giovanni Ferrari <giovanni.ferrari@soft.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants