Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

computeShowDetailCardHeader() has a faulty condition #4608

Closed
ClementBouvierN opened this issue Jun 14, 2023 · 0 comments · Fixed by #4609
Closed

computeShowDetailCardHeader() has a faulty condition #4608

ClementBouvierN opened this issue Jun 14, 2023 · 0 comments · Fixed by #4609
Assignees
@ClementBouvierN
Labels
Bug Something isn't working

Comments

@ClementBouvierN
Copy link
Contributor

in the function, there is this test:
!this.cardState.showDetailCardHeader || this.cardState.showDetailCardHeader === true

which always return true
ClementBouvierN added a commit that referenced this issue Jun 14, 2023
@ClementBouvierN
Fixed the showDetailCardHeader test #4608
391744d 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
@ClementBouvierN ClementBouvierN mentioned this issue Jun 14, 2023
Merged
@ClementBouvierN ClementBouvierN linked a pull request Jun 14, 2023 that will close this issue
Fixed the showDetailCardHeader test #4608 #4609
Merged
ClementBouvierN added a commit that referenced this issue Jun 14, 2023
@ClementBouvierN
Fixed the showDetailCardHeader test #4608
8471b58 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
@freddidierRTE freddidierRTE added the Bug Something isn't working label Jun 14, 2023
ClementBouvierN added a commit that referenced this issue Jun 15, 2023
@ClementBouvierN
Fixed the showDetailCardHeader test #4608
d15914e 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
@ClementBouvierN ClementBouvierN self-assigned this Jun 15, 2023
ClementBouvierN added a commit that referenced this issue Jun 15, 2023
@ClementBouvierN
Fixed the showDetailCardHeader test #4608
b1fcb83 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
ClementBouvierN added a commit that referenced this issue Jun 15, 2023
@ClementBouvierN
Fixed the showDetailCardHeader test #4608
9538743 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
ClementBouvierN added a commit that referenced this issue Jun 16, 2023
@ClementBouvierN
Fixed the showDetailCardHeader test #4608
51e7ea0 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
vlo-rte pushed a commit that referenced this issue Jun 16, 2023
@ClementBouvierN @vlo-rte
Fixed the showDetailCardHeader test #4608
1d9afd8 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
vlo-rte pushed a commit that referenced this issue Jun 16, 2023
@ClementBouvierN @vlo-rte
Fixed the showDetailCardHeader test #4608
987fbd8 
Signed-off-by: ClementBouvierN <clement.bouvierneveu@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ClementBouvierN ClementBouvierN

Labels
Bug Something isn't working
Projects
No open projects
OperatorFabric Release 4.0.0
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the showDetailCardHeader test #4608 opfab/operatorfabric-core
2 participants
@freddidierRTE @ClementBouvierN