feat(evpn): complete fastpath implementation of new arch #384
Conversation
atulpatel261194
force-pushed
the
drop1.0
branch
2 times, most recently
from
0e1e022
to
b1bad1b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Dimitrios Markou <dimitrios.markou@ericsson.com> Co-authored-by: Saikumar Banoth <banoth.saikumar@intel.com> Co-authored-by: Patel Atul <Atul.patel@intel.com> Co-authored-by: Vemula Venkatesh <venkatesh.vemula@intel.com> Co-authored-by: Jambekar Vishakha <vishakha.jambekar@intel.com> Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
atulpatel261194
force-pushed
the
drop1.0
branch
2 times, most recently
from
ea1662f
to
56baf8e
Compare
|
Hello @atulpatel261194 can you please update the description to this one ? Introducing the complete implementation for fastpath based on the new opi-evpn-br architecture that has been presented to opi-tsc in 15 Feb 2024 link This PR includes: Modular based implementation according to the architecture |
There was a problem hiding this comment.
My main question, if it is possible to split the PR to smaller chunks to ease the review process. I see that we can at least organize as separate PRs our preparation steps:
- add of DeInit functionality
- some patch to EventBus with subscribe/unsubscribe
- netlink watcher,
- ...
and finally: - e2000 plugin
Hello @artek-koltun, The plan that has been presented and agreed by the TSC is to have the two big PRs (drop-0.5 and drop-1.0) first and then for any further development we can make smaller PRs. We have developed the code according that plan. However I understand that it is difficult to review such big PRs in the smallest detail so I think I can discuss with the team to split the drop-1.0 PR in 3 smaller chunks (netlinkWatcher, e2000 plugin and the rest of the code) just to make the review process easier but I cannot go further than that. Of course this will make the testing and bug fixing really hard for us but let me discuss with the team first. If you are ok with that split then maybe we can do it. |
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
===========================================
- Coverage 50.77% 13.54% -37.23%
===========================================
Files 37 49 +12
Lines 2525 10252 +7727
===========================================
+ Hits 1282 1389 +107
- Misses 1114 8695 +7581
- Partials 129 168 +39 ☔ View full report in Codecov by Sentry. |
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
Inbanoth
force-pushed
the
drop1.0
branch
2 times, most recently
from
23b91ca
to
460a6fa
Compare
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Introducing the complete implementation for fastpath based on the new opi-evpn-br architecture that has been presented to opi-tsc in 15 Feb 2024 link
This PR includes:
This PR has dependancy on Netlink Watcher( #385) , Intel Vendor Plugin(#386). Once these 2 PRs ( #385 , #386 ) get merged, We will rebase current PR (#384) to main.
The Current PR (#384) Will be the Last PR to be merged.