Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add otel grpc for monitoring #683

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat: add otel grpc for monitoring #683

merged 1 commit into from
Oct 5, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Sep 29, 2023 •
edited

@glimchb glimchb marked this pull request as ready for review September 29, 2023 21:20
@glimchb glimchb requested a review from a team as a code owner September 29, 2023 21:20
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited

Codecov Report

Merging #683 (73ff887) into main (0a83504) will decrease coverage by 0.49%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   76.05%   75.57%   -0.49%     
==========================================
  Files          37       38       +1     
  Lines        3571     3594      +23     
==========================================
  Hits         2716     2716              
- Misses        772      795      +23     
  Partials       83       83
Files Coverage Δ
pkg/utils/trace.go 0.00% <0.00%> (ø)

@glimchb glimchb marked this pull request as draft September 30, 2023 01:05
@glimchb glimchb added bug Something isn't working and removed Merge Candidate in the open merge window, next candidate for merge labels Sep 30, 2023
@glimchb
Copy link
Member Author

glimchb commented Sep 30, 2023 •
edited

Need to use: grpc_middleware.ChainUnaryServer or grpc.ChainUnaryInterceptor

@glimchb glimchb marked this pull request as ready for review October 2, 2023 15:40
@glimchb glimchb added Merge Candidate in the open merge window, next candidate for merge and removed bug Something isn't working labels Oct 2, 2023
@glimchb glimchb added bug Something isn't working and removed Merge Candidate in the open merge window, next candidate for merge labels Oct 2, 2023
@glimchb glimchb marked this pull request as draft October 2, 2023 22:24
@glimchb glimchb force-pushed the otel branch 2 times, most recently from 477e28e to 5da5dcd Compare October 3, 2023 21:44
This was referenced Oct 4, 2023
Closed
Closed
Closed
Closed
@glimchb glimchb force-pushed the otel branch 5 times, most recently from ac11901 to d7ae1c0 Compare October 4, 2023 01:59
@glimchb glimchb removed the bug Something isn't working label Oct 4, 2023
@glimchb glimchb force-pushed the otel branch 2 times, most recently from c09cb0c to 473222f Compare October 4, 2023 02:14
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Oct 4, 2023
@glimchb glimchb marked this pull request as ready for review October 4, 2023 02:19
@glimchb glimchb mentioned this pull request Oct 4, 2023
Closed
@glimchb glimchb linked an issue Oct 4, 2023 that may be closed by this pull request
Add otel for tracing #692
Closed
sandersms
sandersms approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glimchb
feat: add otel grpc for monitoring
73ff887 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
artek-koltun
artek-koltun requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent merging. Want to review it tomorrow

This was referenced Oct 4, 2023
Merged
Merged
Merged
@artek-koltun artek-koltun merged commit d023481 into opiproject:main Oct 5, 2023
16 of 18 checks passed
@glimchb glimchb deleted the otel branch October 5, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artek-koltun artek-koltun artek-koltun approved these changes

@sandersms sandersms sandersms approved these changes

Assignees
No one assigned
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add otel for tracing
3 participants
@glimchb @artek-koltun @sandersms