feat: vfiouser transport created by default #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Codecov Report
@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 75.06% 75.06%
=======================================
Files 40 40
Lines 3634 3634
=======================================
Hits 2728 2728
Misses 824 824
Partials 82 82 |
glimchb
requested changes
Nov 9, 2023
There was a problem hiding this comment.
sorry @artek-koltun I don't understand... where do you want to use vhost expect kvm ?
I want to extend godpu with frontend pcie tests. In SPDK bridge vfio-user transport corresponds to that part, so I think we could start vfio-user by default(without attaching to a qemu instance). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run vfiouser transport by default when the bridge is started. At the moment, a dir for a controller should be created manually, if -kvm option is not used. We may consider moving the directory creation code from kvm server into vfiouser transport