Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PHP 8.1 support to 3.x #102

Closed
GrahamCampbell opened this issue Aug 31, 2021 · 10 comments
Closed

Backport PHP 8.1 support to 3.x #102

GrahamCampbell opened this issue Aug 31, 2021 · 10 comments

Comments

@GrahamCampbell
Copy link
Contributor

I will handle this task next week. Related: 48557b5.

@nunomaduro
Copy link

@GrahamCampbell This can be closed, as we will be maintaining our own fork.

@xpader
Copy link

xpader commented Sep 14, 2021

fork???

@GrahamCampbell
Copy link
Contributor Author

Because we had to make breaking changes to get it to work, and the 4.x branch on this repo is already reserved for the FFI version, which is currently unsuitable for use with php-fpm.

@sorinsarca
Copy link
Member

@GrahamCampbell can you tell me why is not (properly) working with php-fpm?
I've used php-fpm to test it and I had no issues

@nunomaduro
Copy link

nunomaduro commented Sep 14, 2021

FFI may work with PHP FPM, but it's simply not enabled by default.

@sorinsarca
Copy link
Member

You mean the ffi extension?

@nunomaduro
Copy link

@sorinsarca Correct. Edited my previous comment.

@GrahamCampbell
Copy link
Contributor Author

It's also very slow to initialize, and there have been no improvements to address told starts with fpm.

@sorinsarca
Copy link
Member

It is slower in dev mode, when you don't use preloading. Try it with preload enabled

You just have to add in your preload file a single line

\Opis\Closure\Library::preload();

@xpader
Copy link

xpader commented Sep 15, 2021

I think we still need no FFI version, or auto detect and use FFI when it's enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants