Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CMake branch with master #119

Closed
rolk opened this issue Jan 21, 2013 · 8 comments
Closed

Merge CMake branch with master #119

rolk opened this issue Jan 21, 2013 · 8 comments
Assignees

Comments

@rolk
Copy link
Member

rolk commented Jan 21, 2013

No description provided.

@bska
Copy link
Member

bska commented Jan 21, 2013

I don't think we should merge this branch until we know if it fixes issue #113 automatically or how much work it will be to fix that issue in the context of CMake. We absolutely cannot ship a release until #113 is corrected.

@totto82
Copy link
Member

totto82 commented Jan 23, 2013

It seems opm-core is build correctly know (see #113).

Are the tutorials supposed to be build automatically in the CMake branch as they did in Master? For the moment they don't.

I tried to build them manually (using g++), but I struggle to link them to OPM. Most probably the reason is lack of competence in c++. Any hints?

@atgeirr
Copy link
Member

atgeirr commented Jan 29, 2013

I understand that this task is getting closer to merging. It is my opinion that we need a (possibly short) transition period in which both autotools and cmake can be used, both systems living on the same, single branch. After comparison testing we can then drop autotools.

Is this what you are preparing, @rolk?

@kristinf
Copy link
Member

kristinf commented Feb 1, 2013

I have problems linking the opm-core correctly when I have built the cmake branch. I followed your steps from the OPM mailinglist posted today and downloaded the dune modules, opm-core and dune-cornerpoint. With dunecontrol it does not find opm-core when building dune-cornerpoint even though the opm-core cmake branch was built and installed correctly. I have no problems building everything with autotools for the opm-core master branch.

@rolk
Copy link
Member Author

rolk commented Feb 1, 2013

@kristinf
Please post opm-core/CMakeFIles/CMake*.log and dune-cornerpoint/config.log in issue #137

@blattms
Copy link
Member

blattms commented Feb 2, 2013

On Fri, Feb 01, 2013 at 07:41:42AM -0800, Kristin Flornes wrote:

I have problems linking the opm-core correctly when I have built the cmake branch. I followed your steps from the OPM mailinglist posted today and downloaded the dune modules, opm-core and dune-cornerpoint. With dunecontrol it does not find opm-core when building dune-cornerpoint even though the opm-core cmake branch was built and installed correctly. I have no problems building everything with autotools for the opm-core master branch.

I remember that we has similar problems with the DUNE cmake
branches. On my system everything worked fine, but e.g. Christoph had
problems with missing symbols. It turned out that my CMake version did
build the libraries in a way such that libraries that it depended on
where either incorporate (static linking) or link information was put
in the library. For some CMake version this was not the case and we
ended up with providing all necessary libraries to the linker.

Could be the problem here, if opm-core depends on some libraries that
are missing in the test for it.

@rolk
Copy link
Member Author

rolk commented Feb 3, 2013

@blattms

CMake built the libraries in a way such that libraries that it depended on where either incorporate (static linking) or
link information was put in the library. For some versions this was not the case

That is certainly an interesting lead that we'll be looking into. Your intuition have been amazingly correct before :-)

@rolk
Copy link
Member Author

rolk commented Feb 12, 2013

The cmake branch has now been merged with master in the branch release/2013.03 (which at a later stage will be merged into master)

@rolk rolk closed this as completed Feb 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants