firewall: port can be zero in automatic rule, render accordingly

PR: https://forum.opnsense.org/index.php?topic=36885.0 (cherry picked from commit a2d55c8)
opnsense · Nov 9, 2023 · 3e380ff · 3e380ff
1 parent d1006d4
commit 3e380ff
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php b/src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
@@ -329,7 +329,7 @@ public function isUIFromNot()
     }
     public function getUIFromPort()
     {
-        if (!empty($this->rule['from_port'])) {
+        if (isset($this->rule['from_port']) && $this->rule['from_port'] != '') {
             return $this->rule['from_port'];
         } elseif (isset($this->rule['source']['port'])) {
             return $this->rule['source']['port'];
@@ -355,7 +355,7 @@ public function isUIToNot()
     }
     public function getUIToPort()
     {
-        if (!empty($this->rule['to_port'])) {
+        if (isset($this->rule['to_port']) && $this->rule['to_port'] != '') {
             return $this->rule['to_port'];
         } elseif (isset($this->rule['destination']['port'])) {
             return $this->rule['destination']['port'];