Skip to content

Commit

Permalink
(mvc) overlapping variables leading to scope issues in php7/phalcon v…
Browse files Browse the repository at this point in the history
…olt templates
  • Loading branch information
AdSchellevis committed Nov 24, 2016
1 parent 52bfec3 commit caa742c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/opnsense/mvc/app/views/layout_partials/base_form.volt
Expand Up @@ -85,6 +85,8 @@ data_title : data-title to set on form
{% if help|default(false) %}<small>{{ lang._('full help') }} </small><a href="#"><i class="fa fa-toggle-off text-danger" id="show_all_help_{{id}}" type="button"></i></a>{% endif %}
</td>
</tr>
{% set advanced=false %}
{% set help=false %}
{% for field in fields|default({})%}
{% if field['type'] == 'header' %}
{# close table and start new one with header #}
Expand Down

3 comments on commit caa742c

@fichtner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdSchellevis is this the fix for the basic/advanced view issue? :)

@AdSchellevis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fichtner yes

@fichtner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purrfect, you just made my day!

adorable-kitties-kitties-18082710-500-375

Please sign in to comment.