Firewall: Log Files: Live View - change cleanup a bit so it keeps fil…

…tered items longer available. The trick in this case is relatively simple, by splitting the cleanup in visible and invisible items, we keep visible items longer on screen at the (small) cost of using a little more memory.

might solve part of the problem #6833 tries to solve.

(cherry picked from commit 854043d)

src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt

@@ -312,8 +312,14 @@
                     // apply filter after load
                     apply_filter();
 
-                    // limit output, try to keep max X records on screen.
-                    $("#grid-log > tbody > tr:gt("+max_rows+")").remove();
+                    /**
+                     * Limit output, try to keep max X records on screen.
+                     * By removing the invisible items first, we should be able to keep the filtered ones
+                     * longer in scope. In theory the number of items in memory can grow to 2 x max_rows, but
+                     * in practice that's not really an issue.
+                     */
+                    $("#grid-log > tbody > tr:not(:visible):gt("+max_rows+")").remove();
+                    $("#grid-log > tbody > tr:visible:gt("+max_rows+")").remove();
 
                     // bind info buttons
                     $(".act_info").unbind('click').click(function(){