status_rrd_graph.php loads, but has no graphs

[ortylp]

15.1.8.2-32aeeab6b (amd64)

the log is full of enries like this:
opnsense: /status_rrd_graph_img.php: Failed to create graph with error code 1, the error is: ERROR: Could not make sense out of '--start'/usr/local/bin/rrdtool graph /tmp/system-mbuf.rrd-fouryear?refresh_date=20150326221858.png --start 1301174338 --end 1427404738 --step 86400 --vertical-label "utilization, percent" --color SHADEA#eeeeee --color SHADEB#eeeeee --title "OPNsense.localdomain - System :: Mbuf clusters - 4 years - 1 day average" --height 200 --width 620 DEF:"current=/var/db/rrd/system-mbuf.rrd:current:AVERAGE:step=86400" DEF:"cache=/var/db/rrd/system-mbuf.rrd:cache:AVERAGE:step=86400" DEF:"total=/var/db/rrd/system-mbuf.rrd:total:AVERAGE:step=86400" DEF:"max=/var/db/rrd/system-mbuf.rrd:max:AVERAGE:step=86400" LINE2:"current#0080FF:current" LINE2:"cache#00E344:cache" LINE2:"total#FF0000:total" LINE2:"max#000000:max" COMMENT:"\n" COMMENT:" minimum average maximum current\n" COMMENT:"Current. " GPRINT:"current:MIN:%7.2lf %s " GPRINT:"current:AVERA

[ortylp]

the situation above was observed after update from 15.1.8.1 to 15.1.8.2. After reboot graphs are back there.

[fichtner]

I checked this yesterday and 15.1.8.2 seemed fine from here too. Can I close this issue?

[ortylp]

Lets assume, that we want to have updates, that do not require reboots. In this case this is a bug, that needs to be fixed in the context of rebootless updates.
I do agree that it is a minor inconvenience, but I can imagine, that there are cases, when router cannot be rebooted as it would cause a few (unacceptable) downtime minutes.
In my case it does not matter, I do turn off network infrastructure as soon as do not need it (so a few powerdowns a day), but if we target industrial 24/7 uptime and quality, the we need to get it fixed too...

[fichtner]

Before assuming, let's say this actually happened despite the fact that it shouldn't. It happens. Yes, we screwed up. It still happens. We are human. We don't get paid. The BSD license makes no promises with regard to quality, liability, damage, etc. Best part is this is a free project. :)

Assuming does, however, not help to trace down this bug, which is also on the low side of the priority item list due to the fact that RDD graphs are not a mission critical system. Compare that to the last two days of work we spent on amending the aliases situation.

We are far from industry standards here with a legacy code base with missing transparency that we had to bring back to the public, not a single unit test, lack of coding style, at least 5 years worth of missing drive to innovate and clean ups. We as OPNsense have worked on fixing this since November 2014, we've been around publicly since January 2015. If that is not enough that's not good, because that's what we can offer. Not more, not less.

May I close this issue or will you help to trace this down?

[ortylp]

@fichtner please do not get into attack/defence mode, If would not care about FOSS I would not be here reporting bugs in the first place. At the moment I am positively surprised with the speed the project reacts and fixes minor bugs :) As long as I stay using the software I will report ALL bugs I come across.

As already stated for me this bug was a minor inconvenience. The issue stays here for further reference. Fort the time being we can agree to close the issue with status WONTFIX.

[fichtner]

@ortylp I am sorry if it came across this way. To some degree I have to draw the line and keep the balance for the few resources that we have. We've come a long way in just a few months and I know that some decisions need to be made to keep this progress up. I love the project and the people and their feedback. Without the community we wouldn't be this far. Thank you. :)

[fichtner]

Reopening due to https://forum.opnsense.org/index.php?topic=329.0

The code is correct and works in the test setups. rrdtool complains about '--start' which is a viable command as far as the appended command line afterwards shows. No idea what is going on...

[fichtner]

closing this once more, hopefully never to return after the two patches went in.