Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squid: visible_hostname {{OPNsense.proxy.general.VisibleHostname}} #1888

Closed
shacal opened this issue Oct 22, 2017 · 5 comments
Closed

squid: visible_hostname {{OPNsense.proxy.general.VisibleHostname}} #1888

shacal opened this issue Oct 22, 2017 · 5 comments
Assignees
@fichtner
Labels
cleanup Low impact changes
Milestone
18.1

Comments

@shacal
Copy link

shacal commented Oct 22, 2017

Gives in clean install "localhost" as an result.
And exposes header: Via: 1.1 localhost (squid/3.5.27)
@fichtner fichtner self-assigned this Oct 23, 2017
fichtner added a commit that referenced this issue Oct 23, 2017
@fichtner
web proxy: remove default value of visible_hostname
96e1a47 
Since this is not mandatory, better to leave it out unless
one requires this information in the header explicitly.

PR: #1888
@fichtner fichtner added the cleanup Low impact changes label Oct 23, 2017
@fichtner fichtner added this to the 18.1 milestone Oct 23, 2017
@fichtner
Copy link
Member

@shacal thanks for the report! I removed the default value of "localhost" making this feature opt-in, but only when we release new images, which is OPNsense 18.1. Is this fix ok for you?

@shacal
Copy link
Author

shacal commented Oct 23, 2017

Sure, in fine with this.
Would like an field on web UI 🙈

@fichtner
Copy link
Member

@shacal not sure what you mean, it's on the UI :)

General Proxy Settings: enable "advanced mode"

fichtner added a commit that referenced this issue Oct 25, 2017
@fichtner
web proxy: remove default value of visible_hostname
e99275d 
Since this is not mandatory, better to leave it out unless
one requires this information in the header explicitly.

PR: #1888
(cherry picked from commit 96e1a47)
@shacal
Copy link
Author

shacal commented Oct 25, 2017

I mean that even empty "" hostname or toggle to have that in config or not.
As that info should not be exported.

@fichtner
Copy link
Member

@shacal try again with the patch, run from the root shell:

# opnsense-patch e99275d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

Labels
cleanup Low impact changes
Milestone
18.1
Development

No branches or pull requests
2 participants
@fichtner @shacal