Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should not ping the internet by default #2

Closed
fichtner opened this issue Jan 3, 2015 · 0 comments
Closed

should not ping the internet by default #2

fichtner opened this issue Jan 3, 2015 · 0 comments
Assignees
@fichtner
Labels
feature Adding new functionality
Milestone
15.7

Comments

@fichtner
Copy link
Member

fichtner commented Jan 3, 2015

this revolves around the initial apinger setup. via @TimelessP (Twitter)
@fichtner fichtner self-assigned this Jan 3, 2015
@fichtner fichtner added this to the 15.7 milestone Jan 3, 2015
@fichtner fichtner added the feature Adding new functionality label Jan 11, 2015
@fichtner fichtner mentioned this issue Jun 16, 2015
Closed
@netrixtardis netrixtardis mentioned this issue Nov 25, 2016
Closed
@kgleason kgleason mentioned this issue Jan 11, 2017
Closed
@abplfab abplfab mentioned this issue Jul 20, 2017
Closed
@monster900 monster900 mentioned this issue Aug 15, 2017
Closed
@ghost ghost mentioned this issue Nov 13, 2017
Closed
@stilez stilez mentioned this issue Jul 27, 2018
Closed
@Flole998 Flole998 mentioned this issue Oct 25, 2018
Closed
@sachaz sachaz mentioned this issue Nov 10, 2018
Closed
@soder10 soder10 mentioned this issue Dec 8, 2018
Closed
@stilez stilez mentioned this issue Dec 20, 2018
Closed
@NoLooseEnds NoLooseEnds mentioned this issue Jan 9, 2019
Closed
@Northguy Northguy mentioned this issue Feb 7, 2019
Closed
@uKev uKev mentioned this issue Feb 17, 2019
Closed
@stilez stilez mentioned this issue Feb 27, 2019
Closed
@bsd-source bsd-source mentioned this issue Apr 19, 2019
Closed
@jsbsmd jsbsmd mentioned this issue Jul 29, 2019
Closed
@exceet-pk exceet-pk mentioned this issue Oct 10, 2019
Closed
@marcelmah marcelmah mentioned this issue Dec 10, 2019
Closed
@MosheL MosheL mentioned this issue Apr 12, 2020
Closed
knan-md added a commit to knan-md/opnsense-core that referenced this issue Mar 18, 2021
@knan-md
firmware/health.sh: refine missing/invalid signature message take opn…
25ba7e2 
…sense#2
@FMJ999 FMJ999 mentioned this issue May 8, 2021
Closed
@upended upended mentioned this issue Jun 4, 2021
Closed
@vnxme vnxme mentioned this issue Aug 29, 2021
Closed
@TheRealBecks TheRealBecks mentioned this issue Dec 15, 2021
Closed
2 tasks
@oli-h oli-h mentioned this issue Mar 13, 2022
Closed
2 tasks
@jorglodita jorglodita mentioned this issue May 11, 2022
Closed
@mlht mlht mentioned this issue Oct 18, 2022
Closed
2 tasks
@Makss39 Makss39 mentioned this issue Nov 23, 2022
Closed
2 tasks
@schasj schasj mentioned this issue Jan 18, 2023
Closed
2 tasks
AdSchellevis added a commit that referenced this issue Jan 19, 2023
@AdSchellevis
VPN/IPsec : php 8 issue, fix : PHP Fatal error: Uncaught TypeError: i…
86ae7e7 
…n_array(): Argument #2 ($haystack) must be of type array, null given in /usr/local/www/vpn_ipsec_phase1.php:997
AdSchellevis added a commit that referenced this issue Jan 19, 2023
@AdSchellevis
VPN/IPsec : php 8 issue, fix : PHP Fatal error: Uncaught TypeError: i…
473b106 
…n_array(): Argument #2 ($haystack) must be of type array, null given in /usr/local/www/vpn_ipsec_phase1.php:997
fichtner pushed a commit that referenced this issue Jan 19, 2023
@AdSchellevis @fichtner
VPN/IPsec : php 8 issue, fix : PHP Fatal error: Uncaught TypeError: i…
e95bb0e 
…n_array(): Argument #2 ($haystack) must be of type array, null given in /usr/local/www/vpn_ipsec_phase1.php:997

(cherry picked from commit 473b106)
@brandlit brandlit mentioned this issue Apr 17, 2023
Closed
@vladgitdev vladgitdev mentioned this issue Jul 28, 2023
Closed
fichtner added a commit that referenced this issue Oct 29, 2023
@fichtner
firewall: actually fix placement by moving into alias migration
63354e8 
When migrating Category this fails with an error:

 Fatal error: Uncaught Error: Call to undefined method OPNsense\Firewall\Category::flushCache() in /usr/local/opnsense/mvc/app/library/OPNsense/Firewall/Util.php:176
 Stack trace:
 #0 /usr/local/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/M1_0_0.php(103): OPNsense\Firewall\Util::attachAliasObject(Object(OPNsense\Firewall\Category))
 #1 /usr/local/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php(711): OPNsense\Firewall\Migrations\M1_0_0->run(Object(OPNsense\Firewall\Category))
 #2 /usr/core/src/opnsense/mvc/script/run_migrations.php(54): OPNsense\Base\BaseModel->runMigrations()
 #3 {main}
   thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Firewall/Util.php on line 176
fichtner referenced this issue Nov 6, 2023
@AdSchellevis
Gateways: Single: Migrate to MVC - rework datastorage layer.
ebc8e34 
This commit moves the default logic into the model so we can reflect current values into virtual fields.
For all relevant "dpinger" fields, we reflect the current value in a field named current_$field, which means we can always query the active value without touching the stored one. Determination of current is as easy as `!empty(model_value) ? model_value : default`.

Refactor the dpinger process to use the current_ fields, since "dpinger_status()" retrieves all instances including the ones not stored, safeguard the config properties to exclude status determination (as loss and latency fields don't exist).

Previously the validation messages seemed to miss some gettext(), re-add these as well and cleanup validation. By calling isFieldChanged() on the array type, we know the gateway object has changed, but not exactly which field, this might lead to some noise, but if we implement a fix for #6978 , we should be able to avoid real issues with the bonus of needing less code.

The calculateCurrent() on the GatewayField ensures we can insert/update the current values after an update as these are nog aware of modifications automatically.

Finally, respect the 120 character screen limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

Labels
feature Adding new functionality
Milestone
15.7
Development

No branches or pull requests
1 participant
@fichtner