Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvc, phalcon framework 4.0, PHP 7.4 #4012

Closed
AdSchellevis opened this issue Apr 1, 2020 · 3 comments · Fixed by #4921
Closed

mvc, phalcon framework 4.0, PHP 7.4 #4012

AdSchellevis opened this issue Apr 1, 2020 · 3 comments · Fixed by #4921
Assignees
@fichtner @AdSchellevis
Labels
feature Adding new functionality
Milestone
21.7

Comments

@AdSchellevis
Copy link
Member

AdSchellevis commented Apr 1, 2020 •
edited

Phalcon 4 will likely break things.

Run into a "Wrong number of parameters" in Phalcon\Mvc\Application->handle(), while upgrading my mac some time ago.

https://docs.phalcon.io/4.0/en/upgrade

Keeping this here for tracking purposes.

Additional dependencies:

php73-pecl-psr
php73-mbstring
@AdSchellevis AdSchellevis added the feature Adding new functionality label Apr 1, 2020
@AdSchellevis AdSchellevis added this to the 21.1 milestone Apr 1, 2020
@AdSchellevis AdSchellevis self-assigned this Apr 1, 2020
@fichtner fichtner modified the milestones: 21.1, 21.7 Jan 10, 2021
@AdSchellevis AdSchellevis changed the title mvc, phalcon framework 4.0, PHP 7.3 mvc, phalcon framework 4.0, PHP 7.4 Feb 10, 2021
AdSchellevis added a commit that referenced this issue Apr 13, 2021
@AdSchellevis
phalcon 4 migration - first batch for #4012
8aa5085 
o replace Phalcon\Session\Adapter\Files with new Phalcon\Session\Adapter\Stream adapter
o replace router->setUriSource() with handle() parameter
o combining sessions between phalcon and legacy php seems to be a bit problematic, first issue seems to be the legacy csrf check. refactor to use phalcon's method and legacy session
AdSchellevis added a commit that referenced this issue Apr 13, 2021
@AdSchellevis
phalcon 4 migration - first batch for #4012
54e05c2 
o replace Phalcon\Session\Adapter\Files with new Phalcon\Session\Adapter\Stream adapter
o replace router->setUriSource() with handle() parameter
o combining sessions between phalcon and legacy php seems to be a bit problematic, first issue seems to be the legacy csrf check. refactor to use phalcon's method and legacy session
o Fix Phalcon Syslog usage in ControllerRoot (wrap in Logger class)
AdSchellevis added a commit that referenced this issue Apr 13, 2021
@AdSchellevis
Phalcon 4 - for #4012
8ad996a 
o session seems to miss standard prefix.
AdSchellevis added a commit that referenced this issue Apr 13, 2021
@AdSchellevis
Phalcon 4 - for #4012
e63924e 
o also Gettext seems to like being wrapped...
AdSchellevis added a commit that referenced this issue Apr 13, 2021
@AdSchellevis
Phalcon 4 - for #4012
59b2375 
o Gettext inheritance
AdSchellevis added a commit that referenced this issue Apr 13, 2021
@AdSchellevis
Phalcon 4 - for #4012
e522efa 
o another handle()
AdSchellevis added a commit that referenced this issue Apr 14, 2021
@AdSchellevis
Phalcon 4 - for #4012
d8aa226 
o Volt: handle registerEngines / VoltEngine changes
o volt templates - missing session reference, bootstrap in ControllerBase
o router getRewriteUri() deprecated
o another handle() in index.php
AdSchellevis added a commit that referenced this issue Apr 14, 2021
@AdSchellevis
Phalcon 4 - for #4012
7081a85 
o  Phalcon\Dispatcher::EXCEPTION_* moved to  Phalcon\Dispatcher\Exception::EXCEPTION_*
AdSchellevis added a commit that referenced this issue Apr 14, 2021
@AdSchellevis
Phalcon 4 - for #4012
18380c9 
o changes in filter handling.
AdSchellevis added a commit that referenced this issue Apr 14, 2021
@AdSchellevis
Phalcon 4 - for #4012
9032120 
o fix plist
AdSchellevis added a commit that referenced this issue Apr 14, 2021
@AdSchellevis
Phalcon 4 - for #4012
4bdcb63 
o Syslog usage changes
AdSchellevis added a commit that referenced this issue Apr 14, 2021
@AdSchellevis
Phalcon 4 - for #4012
cef3b36 
o refactor Validation changes
AdSchellevis added a commit that referenced this issue Apr 15, 2021
@AdSchellevis
Phalcon 4 - for #4012
7a35b48 
o FILTER_ALNUM - replaced FILTER_ALPHANUM
@fichtner fichtner linked a pull request Apr 15, 2021 that will close this issue
Fr4012 phalcon4 #4921
Merged
fichtner added a commit that referenced this issue Apr 15, 2021
@fichtner
Phalcon 4 migration (#4921)
3a98ebb 
phalcon 4 migration  #4012

o replace Phalcon\Session\Adapter\Files with new Phalcon\Session\Adapter\Stream adapter
o replace router->setUriSource() with handle() parameter
o combining sessions between phalcon and legacy php seems to be a bit problematic, first issue seems to be the legacy csrf check. refactor to use phalcon's method and legacy session
o Fix Phalcon Syslog usage in ControllerRoot (wrap in Logger class)
o session seems to miss standard prefix.
o also Gettext seems to like being wrapped...
o Gettext inheritance
o another handle()
o Volt: handle registerEngines / VoltEngine changes
o volt templates - missing session reference, bootstrap in ControllerBase
o router getRewriteUri() deprecated
o another handle() in index.php
o  Phalcon\Dispatcher::EXCEPTION_* moved to  Phalcon\Dispatcher\Exception::EXCEPTION_*
o changes in filter handling.
o fix plist
o Syslog usage changes
o refactor Validation changes
o FILTER_ALNUM - replaced FILTER_ALPHANUM
@fichtner fichtner reopened this Apr 15, 2021
AdSchellevis added a commit that referenced this issue Apr 18, 2021
@AdSchellevis
missed some small spots in #4012
0013259 
o one syslog unwrapped
o testsuite return class path missing
AdSchellevis added a commit that referenced this issue Apr 18, 2021
@AdSchellevis
phalcon 4, missed another Syslog for #4012
65637ce
@fichtner
Copy link
Member 

% git ls-files | grep OPNsense.Base
www/nginx/src/opnsense/mvc/app/models/OPNsense/Base/Constraints/NaxsiIdentifierConstraint.php
www/nginx/src/opnsense/mvc/app/models/OPNsense/Base/Constraints/NgxBusyBufferConstraint.php

@AdSchellevis
Copy link
Member Author

@fichtner I also need to check the firewall api plugin, for nginx I propose to add a ticket for @fabianfrz to check / modify for compatibility with Phalcon 4.1.

# grep -r Phalcon /usr/plugins
/usr/plugins/net/firewall/src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php:use Phalcon\Validation\Message;

AdSchellevis added a commit to opnsense/plugins that referenced this issue Apr 20, 2021
@AdSchellevis
net/firewall - phalcon 4 compatbility for opnsense/core#4012
6c7b0db
@AdSchellevis AdSchellevis mentioned this issue Apr 20, 2021
Closed
agh1467 pushed a commit to agh1467/plugins that referenced this issue Apr 20, 2021
@AdSchellevis @agh1467
net/firewall - phalcon 4 compatbility for opnsense/core#4012
eb383ee
AdSchellevis added a commit that referenced this issue May 20, 2021
@AdSchellevis
Firewall - live log : small Phalcon 4 regression (ref #4012)
2cce435
@fichtner
Copy link
Member

First build based on PHP 7.4 available. Need to check runtime and https://www.php.net/manual/en/migration74.incompatible.php for good measure.

@fichtner fichtner self-assigned this May 28, 2021
fichtner added a commit that referenced this issue Jun 14, 2021
@fichtner
phalcon 4 migration #4012
1c9bfad 
o replace Phalcon\Session\Adapter\Files with new Phalcon\Session\Adapter\Stream adapter
o replace router->setUriSource() with handle() parameter
o combining sessions between phalcon and legacy php seems to be a bit problematic, first issue seems to be the legacy csrf check. refactor to use phalcon's method and legacy session
o Fix Phalcon Syslog usage in ControllerRoot (wrap in Logger class)
o session seems to miss standard prefix.
o also Gettext seems to like being wrapped...
o Gettext inheritance
o another handle()
o Volt: handle registerEngines / VoltEngine changes
o volt templates - missing session reference, bootstrap in ControllerBase
o router getRewriteUri() deprecated
o another handle() in index.php
o  Phalcon\Dispatcher::EXCEPTION_* moved to  Phalcon\Dispatcher\Exception::EXCEPTION_*
o changes in filter handling.
o fix plist
o Syslog usage changes
o refactor Validation changes
o FILTER_ALNUM - replaced FILTER_ALPHANUM
o missed another Syslog
o Phalcon 4 translations
o one syslog unwrapped
o testsuite return class path missing

(cherry picked from commit 3a98ebb)
(cherry picked from commit 65637ce)
(cherry picked from commit 8bf56bf)
(cherry picked from commit f3e2f8e)
(cherry picked from commit 2cce435)
(cherry picked from commit 0013259)
AdSchellevis pushed a commit that referenced this issue Aug 15, 2021
@fichtner @AdSchellevis
Phalcon 4 migration (#4921)
aca5370 
phalcon 4 migration  #4012

o replace Phalcon\Session\Adapter\Files with new Phalcon\Session\Adapter\Stream adapter
o replace router->setUriSource() with handle() parameter
o combining sessions between phalcon and legacy php seems to be a bit problematic, first issue seems to be the legacy csrf check. refactor to use phalcon's method and legacy session
o Fix Phalcon Syslog usage in ControllerRoot (wrap in Logger class)
o session seems to miss standard prefix.
o also Gettext seems to like being wrapped...
o Gettext inheritance
o another handle()
o Volt: handle registerEngines / VoltEngine changes
o volt templates - missing session reference, bootstrap in ControllerBase
o router getRewriteUri() deprecated
o another handle() in index.php
o  Phalcon\Dispatcher::EXCEPTION_* moved to  Phalcon\Dispatcher\Exception::EXCEPTION_*
o changes in filter handling.
o fix plist
o Syslog usage changes
o refactor Validation changes
o FILTER_ALNUM - replaced FILTER_ALPHANUM
AdSchellevis added a commit that referenced this issue Aug 15, 2021
@AdSchellevis
missed some small spots in #4012
a1ecf13 
o one syslog unwrapped
o testsuite return class path missing
AdSchellevis added a commit that referenced this issue Aug 15, 2021
@AdSchellevis
phalcon 4, missed another Syslog for #4012
2531d74
AdSchellevis added a commit that referenced this issue Aug 15, 2021
@AdSchellevis
Firewall - live log : small Phalcon 4 regression (ref #4012)
194f256
AdSchellevis pushed a commit that referenced this issue Aug 15, 2021
@fichtner @AdSchellevis
src: avoid htmlentities() if possible: closes #4012
770bad7 
Leave config write as is.  There are no other relevant migrations
for PHP 7.4 and it works well in practice already.
oshogbo pushed a commit to DynFi/opnsense-core that referenced this issue Mar 3, 2022
@AdSchellevis
missed some small spots in opnsense/core#4012
461271a 
o one syslog unwrapped
o testsuite return class path missing
oshogbo pushed a commit to DynFi/opnsense-core that referenced this issue Mar 3, 2022
@AdSchellevis
phalcon 4, missed another Syslog for opnsense/core#4012
be3af18
oshogbo pushed a commit to DynFi/opnsense-core that referenced this issue Mar 3, 2022
@AdSchellevis
Firewall - live log : small Phalcon 4 regression (ref opnsense/core#4012
fb5ce0d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

@AdSchellevis AdSchellevis

Labels
feature Adding new functionality
Milestone
21.7
Development

Successfully merging a pull request may close this issue.

Fr4012 phalcon4 opnsense/core
2 participants
@fichtner @AdSchellevis