Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invidual DHCP static host gateway override "none" fails #4843

Closed
TheLinuxGuy opened this issue Mar 19, 2021 · 1 comment
Closed

Invidual DHCP static host gateway override "none" fails #4843

TheLinuxGuy opened this issue Mar 19, 2021 · 1 comment
Assignees
Labels
feature Adding new functionality

Comments

@TheLinuxGuy
Copy link

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

A DHCPv4 service on an interface allows setting 'gateway=none' globally. When creating a static DHCP assignment for a single host/ip/mac, under gateway overrides for that host 'gateway=none' throws an error.

This is seen as unexpected, I should be able to override this one host's gateway setting that may be global. "none" works when set at interface level - therefore an override should be possible at host level.

Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)

To Reproduce


OPNsense 21.1.3-amd64FreeBSD 12.1-RELEASE-p14-HBSDOpenSSL 1.1.1j 16 Feb 2021

Steps to reproduce the behavior:

  1. Go to Services > DHCPv4 > LAN
  2. Click on / add a "DHCP Static Mappings " for a single host mac and IP pair.
  3. On the newly created entry, override gateway with "none" value
  4. See error
The following input errors were detected:

A valid IP address must be specified for the gateway.
The gateway address none does not lie within the chosen interface's subnet.

Expected behavior

Override "none" for gateway address should NOT fail in the individual static mapping page. It does work fine on the parent interface global setting "none"

Describe alternatives you considered

There isn't any other than manual overriding at client level. We want the DHCP server to respond to DHCP DISCOVER with the override values for the mac address. It's broken.

Screenshots

If applicable, add screenshots to help explain your problem.

Relevant log files

If applicable, information from log files supporting your claim.

Additional context

Add any other context about the problem here.

Environment

OPNsense on Promox VE 6.3.3

@AdSchellevis AdSchellevis self-assigned this Mar 19, 2021
@AdSchellevis AdSchellevis added the feature Adding new functionality label Mar 19, 2021
@AdSchellevis
Copy link
Member

The page doesn't suggest "none" is supported, but for consistency I've added it in c4e8018.

Greelan added a commit to Greelan/opnsense-core that referenced this issue Mar 19, 2021
* firmware/health.sh: refine missing/invalid signature message (opnsense#4840)

* IPSec: add legacy validation to prevent saving of route-based tunnels with "install policy" set, since it will drop all traffic unintended

closes opnsense#4838

* Services / DHCPv4 - static entries: add "none" option to gateway setting. Although I really don't like how "none" is a valid option, it will be more consistent with the overal experience. closes opnsense#4843

* webgui: lighttpd include directory for configuration (opnsense#4837)

* webgui.inc: fix syntax error (opnsense#4845)

* opnsense_legacy.js: toString before split (opnsense#4846)

Co-authored-by: Erik Inge Bolsø <61788597+knan-md@users.noreply.github.com>
Co-authored-by: Ad Schellevis <ad@opnsense.org>
Co-authored-by: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
AdSchellevis added a commit that referenced this issue Mar 27, 2021
…ing. Although I really don't like how "none" is a valid option, it will be more consistent with the overal experience. closes #4843
fichtner pushed a commit that referenced this issue Apr 19, 2021
…ing. Although I really don't like how "none" is a valid option, it will be more consistent with the overal experience. closes #4843

(cherry picked from commit c4e8018)
oshogbo pushed a commit to DynFi/opnsense-core that referenced this issue Mar 3, 2022
…ing. Although I really don't like how "none" is a valid option, it will be more consistent with the overal experience. closes opnsense/core#4843
oshogbo pushed a commit to DynFi/opnsense-core that referenced this issue Mar 3, 2022
…ing. Although I really don't like how "none" is a valid option, it will be more consistent with the overal experience. closes opnsense/core#4843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

No branches or pull requests

2 participants