Unbound reporting: stops when a static lease is modified/added/removed

[Christophe999s]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

Unbound reporting stops when a static dhcp lease is modified/added/removed

To Reproduce

Change static dhcp lease
Check unbound reporting

Workaround
Reporting starts again when going into Reporting > Settings and clicking the Save button on Unbound DNS reporting

Screenshots

Additional context
Thread on OPNsense forum:
https://forum.opnsense.org/index.php?topic=32161.0

Software version used and hardware type if relevant, e.g.:

OPNsense 23.1.1_2-amd64
FreeBSD 13.1-RELEASE-p6
OpenSSL 1.1.1t 7 Feb 2023
Intel(R) Core(TM) i5-10400 CPU @ 2.90GHz (4 cores, 4 threads)
Running in Proxmox VM

[AdSchellevis]

Looks like the HUP command kills the pipe between both processes and isn't reopened:

core/src/etc/inc/plugins.inc.d/unbound.inc

Line 46 in 35090ec

'hosts' => array('unbound_hosts_generate:0'),

core/src/etc/inc/plugins.inc.d/unbound.inc

Line 661 in 35090ec

killbypid('/var/run/unbound.pid', 'HUP');

[fichtner]

It might be better to replace the HUP, as it forces unbound to do a complete reload and possibly purging the cache as well (without being able to retain it).

[swhite2]

It's the only part of the code not following the strict restart logic, we can either attempt to reconnect from the logger (which closes itself as soon as Unbound stops), or indeed call unbound_configure_do()

[swhite2]

5f5be7c if @AdSchellevis agrees.

[fichtner]

TBH, the whole 'hosts' logic can be removed and dns restart be issued instead:

% git grep unbound_hosts_generate
src/etc/inc/plugins.inc.d/unbound.inc:        'hosts' => array('unbound_hosts_generate:0'),
src/etc/inc/plugins.inc.d/unbound.inc:function unbound_hosts_generate()
% git grep 'plugin.*hosts'       
src/www/services_dhcp.php:    plugins_configure('hosts');
src/www/services_dhcpv6.php:    plugins_configure('hosts');

[fichtner]

(the same applies to dnsmasq where HUP works, but how often are host overrides edited in batch anyway)

[fichtner]

Should be taken care of then. Not before 23.1.3.