Bug in Unbound Migration Handling of Boolean Values from OPNsense 21.1

[utkonos]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

Earlier versions of OPNsense used "on" rather than "1" in the config.xml. These config entries are causing an error in the Unbound migration in recent OPNsense updates.

To Reproduce

Steps to reproduce the behavior:

1. Install OPNsense from the official ISO for version 21.1: OPNsense-21.1-OpenSSL-dvd-amd64.iso
2. During a plain vanilla install's initial wizard, check the unbound settings that enable DNSSEC configurations.
3. Observe the "on" fields that are added to the config.xml by the wizard.
4. Upgrade to the current version of OPNsense and look in the logs for the error quoted below.

Expected behavior

The current migrations should be able to handle these "on" fields correctly and update them to "1" as is used as the boolean value in config.xml elsewhere.

Describe alternatives you considered

I can manually change these values, but they were created by the OPNsense software itself, so therefore should be handled properly without error in recent updates.

Screenshots

Relevant log files

2023-05-07T00:49:33 | Error | config | #2 {main} ) |  
-- | -- | -- | -- | --
2023-05-07T00:49:33 | Error | config | #1 /usr/local/opnsense/mvc/script/run_migrations.php(54): OPNsense\Base\BaseModel->runMigrations() |  
2023-05-07T00:49:33 | Error | config | #0 /usr/local/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php(704): OPNsense\Base\BaseModel->serializeToConfig() |  
2023-05-07T00:49:33 | Error | config | Stack trace: |  
2023-05-07T00:49:33 | Error | config | in /usr/local/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:583 |  
2023-05-07T00:49:33 | Error | config | [2023-05-07T00:49:33+00:00][ERROR] Model OPNsense\Unbound\Unbound can't be saved, skip ( OPNsense\Phalcon\Filter\Validation\Exception: [OPNsense\Unbound\Unbound:advanced.dnssecstripped] value should be a boolean (0,1){on} |  
2023-05-07T00:49:33 | Error | config | [2023-05-07T00:49:33+00:00][ERROR] [OPNsense\Unbound\Unbound:advanced.dnssecstripped] value should be a boolean (0,1){on}

Environment

Software version used and hardware type if relevant, e.g.:

OPNsense 21.1 (amd64, OpenSSL)
upgraded to
OPNsense 23.1 (amd64, OpenSSL)

[fichtner]

Thanks for the report. The ‚on‘ originated from wizard use which has already been fixed in 0192217 but this is obviously related since the config values can persist. I‘ll take a look tomorrow.