You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
General tab is a bit low on value and just now with #6973 we have a nice way to ensure people find the "enable" checkbox by placing it with the apply button.
Describe the solution you like
In a nutshell remove the tab, maybe rename the Settings to Configuration to align with others (or add the individual tabs into the menu like we do with the firmware menu). Make sure the docs reflect the change but it shouldn't cause the amount of friction of earlier more fundamental reworks.
Describe alternatives you considered
Adding more options to the general settings tab but there aren't any that make sense. ;)
One note from @swhite2 was the possibility of making the enable/apply pattern a reusable hook of some sort.
Also the services hook is not there. It's difficult anyway to display per instance. Just need to check status page and services page more or less align with the whole implementation.
Since @swhite2 was asking to make a generalized pattern I played
with the layout a bit and ended up just moving the form below so
it actually holds more settings if it has. This way the base_form
could be extended to only show a subset of settings (like enable)
but also show the full set if more settings are coming in.
While here adjust the menu structure and remove the ordering of
the VPN types since they order naturally.
Since @swhite2 was asking to make a generalized pattern I played
with the layout a bit and ended up just moving the form below so
it actually holds more settings if it has. This way the base_form
could be extended to only show a subset of settings (like enable)
but also show the full set if more settings are coming in.
While here adjust the menu structure and remove the ordering of
the VPN types since they order naturally.
(cherry picked from commit 935f041)
(cherry picked from commit bc2ca23)
(cherry picked from commit 27c66f6)
(cherry picked from commit 13b685a)
(cherry picked from commit e53da1f)
(cherry picked from commit 768d900)
(cherry picked from commit 550dacf)
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
Is your feature request related to a problem? Please describe.
General tab is a bit low on value and just now with #6973 we have a nice way to ensure people find the "enable" checkbox by placing it with the apply button.
Describe the solution you like
In a nutshell remove the tab, maybe rename the
Settings
toConfiguration
to align with others (or add the individual tabs into the menu like we do with the firmware menu). Make sure the docs reflect the change but it shouldn't cause the amount of friction of earlier more fundamental reworks.Describe alternatives you considered
Adding more options to the general settings tab but there aren't any that make sense. ;)
Additional context
Loosely related to #6973 as mentioned.
The text was updated successfully, but these errors were encountered: