Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: modal-footer padding gone since latest scss cmpile #7463

Closed
2 tasks done
fichtner opened this issue May 17, 2024 · 0 comments
Closed
2 tasks done

ui: modal-footer padding gone since latest scss cmpile #7463

fichtner opened this issue May 17, 2024 · 0 comments
Assignees
Labels
cleanup Low impact changes
Milestone

Comments

@fichtner
Copy link
Member

fichtner commented May 17, 2024

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

d085f4ef36 introduced 0px padding for the modal footer making embedded buttons look stuck to the sides.

To Reproduce

Open any modal.

Expected behavior

Footer should be unaffected by the padding change (retain 15px).

Describe alternatives you considered

N/A

Screenshots

Screenshot 2024-05-17 at 11 52 56

Relevant log files

N/A

Additional context

From 1c8639c:

 .modal-footer {
-  padding: 15px;
+  padding: 0px;
   text-align: right;
   border-top: 1px solid #e5e5e5;
 }

Environment

Current development branch.

@fichtner fichtner added the cleanup Low impact changes label May 17, 2024
@fichtner fichtner added this to the 24.7 milestone May 17, 2024
AdSchellevis added a commit that referenced this issue May 17, 2024
…modal-footer unintentionally, let overwrite it in our main.scss. closes #7463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Low impact changes
Development

No branches or pull requests

2 participants