Wireguard Peer Generator: Field "Allowed IPs" always errors with "A value is required."

[tuxmainy]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When using the WireGuard Peer Generator I am unable to use "Store and generate next" because the field "Allowed IPs" always shows the error "A value is required." no matter what I enter. If the field requires a special value / notation the error message should be changed.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'VPN -> WireGuard -> Peer Generator'
2. type network (e.g. 10.0.0.0/24) in 'Allowed IPs'
3. Click on the check button 'Store and generate next'
4. Allowed IPs gets a red box and the error message "A value is required."

Expected behavior

Store and generate next

Describe alternatives you considered

No way found

Screenshots

See above

Relevant log files
This shows in log files everytime trying to click 'Store and generate next':

2024-05-19T19:53:11 Error config [OPNsense\Wireguard\Server:servers.server.a6d636b1-XXX.peers] Choose a peer.{01cd3b71-YYY}

Additional context

First time using WireGuard. Don't know if this error happens in prior versions, too.

Environment

OPNsense 24.1.7-amd64

[tuxmainy]

On a second server I discovered that Proxy Auto Configuration is not working anymore. Looking at the generated rules I see:

if (((isInNet(dstip, "", "255.255.255.0")))) {
return "DIRECT";
}

This should be a rule matching a network. Please notice the second parameter of isInNet which should be a network address but is "" instead.

I think there is currently something wrong with parsing networks generally. So this issue is not related to wireguard but all configurations using network textboxes?

regards
Daniel

[AdSchellevis]

can't reproduce on a clean install, but looking at the message in the log, the spurious message would better be omitted as referential integrity checks are not possible yet at that point. 611ee6a silences the message.

It might be a good idea to do a firmware health check and perhaps check any browser plugins installed (if any).

[tuxmainy]

I got this on two separate boxes with two different clients. Both installations where updated from an older version to 24.1.7

Anyway, I tried the peer generator in a chromium without any plugins (at least I haven't installed any ;)) with the same result:

BTW: the initial view of the peer generator page looks like this:

As you can see, the Allowed IPs field is already not shown as it should, right?

I will look into the firmware health check and come back with the results. Thanks so far :)

[tuxmainy]

No errors in Health Check:

***GOT REQUEST TO AUDIT HEALTH***
Currently running OPNsense 24.1.7 at Mon May 20 20:54:03 CEST 2024
>>> Root file system: /dev/gpt/rootfs
>>> Check installed kernel version
Version 24.1.5 is correct.
>>> Check for missing or altered kernel files
No problems detected.
>>> Check installed base version
Version 24.1.5 is correct.
>>> Check for missing or altered base files
No problems detected.
>>> Check installed repositories
OPNsense
>>> Check installed plugins
os-ddclient 1.21_2
os-squid 1.0_1
os-zabbix64-agent 1.13_2
os-zabbix64-proxy 1.10_1
>>> Check locked packages
No locks found.
>>> Check for missing package dependencies
Checking all packages: .......... done
>>> Check for missing or altered package files
Checking all packages: .......... done
>>> Check for core packages consistency
Core package "opnsense" has 68 dependencies to check.
Checking packages: ..................................................................... done
***DONE***

[tuxmainy]

Checked all request on reloading page (ignoring cache), but all files are getting loaded with HTTP 200. Two issues regarding "img-src self" in the console but I think they don't matter here.

[tuxmainy]

can't reproduce on a clean install, [...]

Did a clean install of 24.1 by myself. As peer generator is not available I updated to 24.1.7 and the result is:

Double checked this with chromium. Same result.

[tuxmainy]

On a second server I discovered that Proxy Auto Configuration is not working anymore. [...]

This is broken because of the commit 67f6aee which changed the returning object class of the helper function. I don't know if this is related to the WireGuard Peer Generator issue described here. So I will create a new issue on opnsense/plugins for squid proxy.

[fichtner]

The error you see is when there is no tunnel address set in the instance. We're working on a fix.

[AdSchellevis]

right error, wrong field indeed. 4e16134 should fix this