devd does not pick up on laggX_vlanXXXX devices... #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...since the underscore devices are filtered out.
stumbaumr
changed the title
fichtner
reviewed
Sep 24, 2019
|
Looks like this was added last year mimicking FreeBSD scripting 0008970 but you're right about it since we use "_" as an additional character. "." might be interesting sooner or later for VLAN so we should add it as well while here. |
|
Good morning Franco and thanks for picking this up so fast. I can only confirm and test my use case. If you know that the dot is an upcoming issue just add that as well. |
Co-Authored-By: Franco Fichtner <franco@lastsummer.de>
|
Merged, thanks! |
fichtner
pushed a commit
that referenced
this pull request
Sep 29, 2019
...since the underscore devices are filtered out. (cherry picked from commit 201ed68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...since the underscore devices are filtered out.