Nextcloud backup: allow subdir

[maxxer]

Fixes #3988

[AdSchellevis]

@fabianfrz do you have time to spin this for a test?

[fabianfrz]

@AdSchellevis crashes immediately:

Fatal error: Uncaught Error: Call to undefined function OPNsense\Backup\basedir() in /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php:147 Stack trace: #0 /usr/local/www/diag_backup.php(286): OPNsense\Backup\Nextcloud->backup() #1 {main} thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php on line 147

[fabianfrz]

log after fixing the issue by replacing it by basename(), opnsense/backup as file name:

config[60397]: Error while fetching filelist from Nextcloud

{
  "url":"https:\/\/nextcloud.test\/remote.php\/dav\/files\/opnsensebkp\/Backup",
  "content_type":"text\/html; charset=UTF-8",
  "http_code":404,
  "header_size":1220,
  "request_size":205,
  "filetime":-1,
  "ssl_verify_result":0,
  ...
}

Tested on OPNsense 20.1.r_12 (amd64/LibreSSL) - I don't think somebody changed the nextcloud code inbetween

[fabianfrz]

code is broken and not ready to deploy. Test failed.

[maxxer]

Hi @fabianfrz thanks for the feedback.

About the last issue, one question: does opnsensebkp directory exist on your Nextcloud? Because indeed the plugin doesn't create all the path to the backup dir, I left the original behaviour that will create just the last one (Backup in your example). Is it expected differently?

[maxxer]

I'm sorry for the misspelled function name, I meant to use dirname but accidentally copied the wrong file to git :(

[fabianfrz]

now the php error is gone but the backup still fails.

[maxxer]

Does the parent directory exist?

[fabianfrz]

nope, but that is what the code is expected to do, create the full directory hierarchy if missing.

[maxxer]

Ok, I will implement that. I asked two comments ago but got not answer...

[fabianfrz]

Sorry I forgot the answer but if you read the source, there is already MKCOL implemented which is doing this so yes, it is the current behaviour.

[maxxer]

I've updated the patch and merge against current master, I hope it's fine now

[maxxer]

Any chance to get another review?

[hasechris]

Hii,

Any chance to get another review?
@fabianfrz could you please review this merge?

Thanks in advance

[fabianfrz]

I found some improvements for the models but if this changes are in the PR, I can give it a test run.

[fabianfrz]

Tested now successfully:

@AdSchellevis you can merge it now if you like.

[AdSchellevis]

@maxxer @fabianfrz thanks! I will merge it to master