Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCPv6 leases status: Fix interface name search #4526

Closed
wants to merge 1 commit into from
Closed

DHCPv6 leases status: Fix interface name search #4526

wants to merge 1 commit into from

Conversation

vnxme
Copy link
Contributor

@vnxme vnxme commented Dec 14, 2020

Issues in status_dhcpv6_leases.php for which this PR suggests a solution:

  • Incorrect use of $staticent['ipaddr'] instead of $staticent['ipaddrv6'] to match IPv6 of static mappings.

Other:
This PR is a part of changes proposed by #4514.

Use $staticent['ipaddrv6'] instead of $staticent['ipaddr'] to match IPv6 of static mappings.
@fichtner
Copy link
Member

fichtner commented Apr 6, 2021

Sorry, I forgot about this. The code fixed here doesn't exist anymore after working on #4642

@fichtner fichtner closed this Apr 6, 2021
@vnxme
Copy link
Contributor Author

vnxme commented Apr 6, 2021

@fichtner Nice to see you have completely reworked the code of the page. However, for me on 21.1.4 the interface field is completely empty. Seems like a bug around guess_interface_from_ip(). I will investigate the issue and update this post.

@fichtner
Copy link
Member

fichtner commented Apr 6, 2021

I don’t think this is on 21.1.4 yet.

@vnxme
Copy link
Contributor Author

vnxme commented Apr 6, 2021

I don’t think this is on 21.1.4 yet.

Ok, then I will wait untill you release the changes. Hope they will fix the issue with empty interface fields.

@vnxme vnxme deleted the fix-status-dhcpv6-leases-ifs branch April 30, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants